Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TierTwo] P2SH Proposal Payouts #2830

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

panleone
Copy link

@panleone panleone commented Mar 29, 2023

the idea of this PR is taken from #2265.
Having the governance system accept P2SH proposals is a nice addition since, for example, the work of a team can be paid in a single multisig address.
P2SH proposals will be enabled after v6.0 and is not backward compatible: in particular with the current implementation a v6 node will relay a p2sh proposal even to non-v6 nodes (and will lead to non v6 nodes banning the v6 node).
Since v6.0 will be a huge mandatory update I don't think it will be an issue

@panleone panleone marked this pull request as draft March 29, 2023 07:19
@panleone
Copy link
Author

Ready for review: last commit is a bit out of scope and adds CheckString() in IsWellFormed() (It was a waste of time opening another PR just for that line)

@panleone panleone marked this pull request as ready for review March 29, 2023 21:34
@Fuzzbawls Fuzzbawls changed the title P2SH Proposals [TierTwo] P2SH Proposal Payouts Apr 1, 2023
@Fuzzbawls Fuzzbawls added this to the 6.0.0 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

2 participants