Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www-client/ungoogled-chromium : now sys-devel/clang is llvm-core/clang. #398

Open
Arniiiii opened this issue Dec 12, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@Arniiiii
Copy link

emerge: there are no ebuilds to satisfy ">sys-devel/clang-19.0.0_pre20240518".
(dependency required by "www-client/ungoogled-chromium-131.0.6778.108_p1::pf4public[clang,pgo]" [ebuild])
(dependency required by "@selected" [set])
(dependency required by "@world" [argument])

now a lot of stuff is renamed to llvm-core/... or llvm-runtime/...

@Arniiiii Arniiiii added the bug Something isn't working label Dec 12, 2024
@Arniiiii
Copy link
Author

# move sys-devel/lld llvm-core/lld
=llvm-core/lld-20.0.0_pre20241207 **
# move sys-devel/llvm llvm-core/llvm
=llvm-core/llvm-20.0.0_pre20241207 **
# move sys-devel/clang llvm-core/clang
=llvm-core/clang-20.0.0_pre20241207 **
# move sys-devel/clang-runtime llvm-core/clang-runtime
=llvm-core/clang-runtime-20.0.0_pre20241207 **
# move sys-devel/clang-common llvm-core/clang-common
=llvm-core/clang-common-20.0.0_pre20241207 **
# move sys-libs/compiler-rt llvm-runtimes/compiler-rt
=llvm-runtimes/compiler-rt-20.0.0_pre20241207 **
# move sys-libs/compiler-rt-sanitizers llvm-runtimes/compiler-rt-sanitizers
=llvm-runtimes/compiler-rt-sanitizers-20.0.0_pre20241207 **
# move sys-libs/libcxx llvm-runtimes/libcxx
=llvm-runtimes/libcxx-20.0.0_pre20241207 **
# move sys-libs/libcxxabi llvm-runtimes/libcxxabi
=llvm-runtimes/libcxxabi-20.0.0_pre20241207 **
# move sys-libs/libomp llvm-runtimes/openmp
=llvm-runtimes/openmp-20.0.0_pre20241207 **
=dev-python/lit-20.0.0_pre20241207 **
# move sys-devel/llvm-toolchain-symlinks llvm-core/llvm-toolchain-symlinks
=llvm-core/llvm-toolchain-symlinks-20 **
# move sys-devel/clang-toolchain-symlinks llvm-core/clang-toolchain-symlinks
=llvm-core/clang-toolchain-symlinks-20 **
# move sys-devel/llvmgold llvm-core/llvmgold
=llvm-core/llvmgold-20 **
# move sys-devel/lld-toolchain-symlinks llvm-core/lld-toolchain-symlinks
=llvm-core/lld-toolchain-symlinks-20 **

@robertkirkman
Copy link

robertkirkman commented Dec 14, 2024

I would like to append to this that, I have the pgo USE flag enabled, and as a temporary workaround, I changed the requirement for

pgo? ( >sys-devel/clang-19.0.0_pre20240518 >sys-devel/lld-19.0.0_pre20240518	)

to

pgo? ( >=llvm-core/clang-19.1.4 >=llvm-core/lld-19.1.4	)

in /var/db/repos/pf4public/www-client/ungoogled-chromium/ungoogled-chromium-131.0.6778.108_p1.ebuild,

and for me it worked to successfully build and launch with no errors, but it is true that pgo is an extremely complicated subject, and it is difficult to tell whether the compiler used is actually the correct compiler for pgo or not, so in my case it could be that it just worked by luck.

@PF4Public
Copy link
Owner

I'm still watching GitHub activity, unfortunately I'm very limited by time right now, so some things might get greatly delayed (rough estimate till Jan-Feb 2025). I might occasionally have time to merge a PR with minor changes though.

it is difficult to tell whether the compiler used is actually the correct compiler for pgo or not

Fortunately it is not that difficult. With the older compiler you get following error almost immediately:

error: Error in reading profile ../../chrome/build/pgo_profiles/chrome-linux-6778-1731431875-75e60acd68a20cf9cc2c5d6dfbb65ee7b4e60752-a75a9b0cd4f8d4a3bb5d3446daa63b14105e852e.profdata: unsupported instrumentation profile format version

You can see this happen for example here: https://github.com/PF4Public/gentoo-overlay/actions/runs/12214473154/job/34075569788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants