Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add institution: CR #57

Open
znichollscr opened this issue Jul 10, 2024 · 8 comments · May be fixed by #68
Open

Add institution: CR #57

znichollscr opened this issue Jul 10, 2024 · 8 comments · May be fixed by #68

Comments

@znichollscr
Copy link
Contributor

znichollscr commented Jul 10, 2024

New Institution Request

To request a new item please ammend the following template below to reflect the items you are interested in.
Conditions on naming conventions and permissable items can be found on the (WIKI)[https://wiki.mipcvs.dev/CMIP6Plus/Rules/institution/] and relevant github page

Content

NOTE Please review the rules provided in https://wiki.mipcvs.dev/CMIP6Plus/Rules/institution/ before completing this form. Submission of this is an acceptance of any terms outlined in the referenced document at the time.

To get an institutions ROR code we can see if it exists on ror.org. For the entry below, we have the page: https://ror.org/01kk86953


[institution]
    Acronym = "CR"
    Full_Name = "Climate Resource Pty Ltd - Australia"
    ROR = "01kk86953"

@github-actions github-actions bot changed the title New Institution Add Institution: CR Jul 10, 2024
Copy link
Contributor

Sanity Check:

Is 'Climate Resource Pty Ltd - Australia' the same as 'Climate Resource (Australia)'

@znichollscr
Copy link
Contributor Author

@wolfiex just FYI, I tried to use Full_Name = Climate Resource (Australia), but the payload wouldn't parse so I changed it to have no brackets. The resulting PR (#58) looks correct, so it wasn't clear to me what the full name field was actually for.

@wolfiex
Copy link
Collaborator

wolfiex commented Jul 15, 2024

Sanity Check:

Is 'Climate Resource Pty Ltd - Australia' the same as 'Climate Resource (Australia)'

@znichollscr Ah good to know, I shall have to look into it. The full name is just to perfom a sanity check (see above) since acronyms and RORs are not fully intuitive and can allow accidental mistakes to get through.

Copy link
Contributor

Sanity Check

Similarity: 81.25%
["Climate Resource (Australia)" | "Climate Resource Pty Ltd - Australia"]

@github-actions github-actions bot changed the title Add Institution: CR Add institution: CR Sep 19, 2024
Copy link
Contributor

Issue updated: 2024-09-19 12:49:34

Branch: institution-cr-57

{
   "@id": "mip-cmor-tables:organisations/institutions/cr",
   "@type": "institution",
   "acronyms": [
       "CR"
   ],
   "aliases": [
       "Climate Resource",
       "Climate Resource Pty Ltd",
       "Climate Resource Ltd"
   ],
   "cmip_acronym": "CR",
   "established": 2020,
   "kind": "Company",
   "labels": [],
   "location": {
       "@id": "mip-cmor-tables:organisations/institutions/location/01kk86953",
       "@type": "location",
       "@nest": {
           "lat": -37.814,
           "lon": -37.814,
           "city": "Melbourne",
           "country": [
               "Australia",
               "AU"
           ]
       }
   },
   "name": "Climate Resource (Australia)",
   "ror": "01kk86953",
   "url": [
       "https://www.climate-resource.com"
   ]
} 

Copy link
Contributor

New Pull Request: Already up to date.
#68

@github-actions github-actions bot linked a pull request Sep 19, 2024 that will close this issue
@wolfiex
Copy link
Collaborator

wolfiex commented Sep 19, 2024

Do we want to enforce a CMIP acronym of more than three letters? @durack1 @matthew-mizielinski

@durack1
Copy link
Contributor

durack1 commented Sep 19, 2024

@wolfiex these data are already published on ESGF (here) so it's a little late. I don't have a problem with short and unique, if long, then we need to figure out what doesn't make sense - unique, and consistency with existing examples, or past use is key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants