Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmor_version identifier in all tables #142

Open
durack1 opened this issue Jan 24, 2018 · 7 comments
Open

Update cmor_version identifier in all tables #142

durack1 opened this issue Jan 24, 2018 · 7 comments

Comments

@durack1
Copy link
Contributor

durack1 commented Jan 24, 2018

All current tables include "cmor_version": "3.2",, should this be updated to "cmor_version": "3.3",?

@dnadeau4 @taylor13

@taylor13
Copy link
Collaborator

Not sure about this, but I thought the cmor_version was supposed to list the first version of CMOR that would be able to read and interpret a table correctly. If changes are made in CMOR that don't affect its ability to read a CMOR table there would then be no reason for the entry for cmor_version to be changed in the table. The rationale for this is that a user should be able to determine which tables can be read by his version of CMOR3; the answer is "any version later than the one listed in the table".
Is there a better approach?

@durack1
Copy link
Contributor Author

durack1 commented Jan 25, 2018

@taylor13 fair enough, it may be useful to rename this cmor_version_minimum or similar, which would more accurately convey what the information provides.. If it's too hard, then we can just close the issue

@taylor13
Copy link
Collaborator

@dnadeau4 is cmor_version read from these tables? If so, is it used in any way by CMOR3?

If the answer is no to either one of the above, then Paul's suggestion to rename cmor_version in the tables as "cmor_version_minimum" (or similar) is probably a good idea.

@taylor13
Copy link
Collaborator

taylor13 commented Feb 8, 2018

Perhaps we should include all 3 integers in cmor_version, and it's value should be set to the latest existing version of CMOR (at the time any of the tables was modified).

@wachsylon
Copy link

From following lines one can see, the cmor_version global attribute is the version number of the program.

Perhaps we should include all 3 integers in cmor_version, and it's value should be set to the latest existing version of CMOR (at the time any of the tables was modified).

Nevertheless, the information about the minimum CMOR-version suitable to apply the table (with all 3 integers) is of value. For example, if an update of CMOR to a newer version is not possible but more recent tables could be used.

@doutriaux1
Copy link
Contributor

@wachsylon that was how i originally intended this to be used in the tables, if some changes are made to the table that require changes to CMOR, then the attribute would be upped to the minimum version of CMOR that can read this table. Now, thinking about it, I am not 100% sure that once CMOR includes the new requirement it is still able to read the old tables. @taylor13 should we add something to CMOR to reflect that? Or do we assume that once a table is updated one should never again use the old ones?

@slavakharin
Copy link

We started using CMOR3 and got confused about this flag as well. Our initial expectation was that the value should have been 3.3.3, the same as the CMOR software version, until we stumbled on this issue. If this is still the case that the flag indicates the minimum version of CMOR capable of reading the tables, I like the idea of renaming it to cmor_version_minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants