Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pre-existing content for changes due to Duty Support #150

Open
21 of 32 tasks
xiashtra opened this issue May 16, 2024 · 2 comments
Open
21 of 32 tasks

Check pre-existing content for changes due to Duty Support #150

xiashtra opened this issue May 16, 2024 · 2 comments
Labels
enhancement New feature or change to existing functionality fix-me Bug report validated or feature request planned help wanted No one working on this yet - PRs welcome! oopsy /ui/oopsyraidsy module raidboss /ui/raidboss module

Comments

@xiashtra
Copy link
Collaborator

xiashtra commented May 16, 2024

This is a continuation of quisquous#5117

Any triggers/timelines that existed prior to Duty Support coverage being added should be checked for changes. Zones that have had Duty Support added:

Added in 6.1:

  • Sastasha (no prior coverage)
  • The Tam-Tara Deepcroft (no prior coverage)
  • Copperbell Mines (no prior coverage)
  • The Bowl of Embers
  • The Thousand Maws of Toto-Rak (no prior coverage)
  • Haukke Manor
  • Brayflox's Longstop
  • The Navel
  • The Stone Vigil
  • The Howling Eye (no prior coverage)
  • Castrum Meridianum (no prior coverage)
  • The Praetorium (no prior coverage)
  • The Porta Decumana (new zone)

Added in 6.2:

  • Snowcloak
  • The Keeper of the Lake (no prior coverage)
  • Sohm Al
  • The Aery (no prior coverage)
  • The Vault

Added in 6.3:

  • The Great Gubal Library (no prior coverage)
  • The Aetherochemical Research Facility
  • The Antitower (no prior coverage)
  • Sohr Khai (no prior coverage)
  • Xelphatol
  • Baelsar's Wall

Added in 6.4:

Added in 6.5:

  • The Drowned City of Skalla
  • The Burn
  • The Ghimlyt Dark

In addition, the dummy zones/triggers/timelines added for the above content to support KO and CN until they caught up with global release should be removed.

@xiashtra xiashtra added enhancement New feature or change to existing functionality help wanted No one working on this yet - PRs welcome! raidboss /ui/raidboss module oopsy /ui/oopsyraidsy module fix-me Bug report validated or feature request planned labels May 16, 2024
@valarnin
Copy link
Collaborator

(I think that going forward it may be a good idea to open an issue when the duty support patch releases, so it's a bit easier to be on top of these? e.g. when 7.0 drops, if duty support is added to older content, an issue should be opened specifically for that patch so that it's not lost/forgotten about like these ones seem to have been?)

@xiashtra
Copy link
Collaborator Author

xiashtra commented May 17, 2024

(I think that going forward it may be a good idea to open an issue when the duty support patch releases, so it's a bit easier to be on top of these? e.g. when 7.0 drops, if duty support is added to older content, an issue should be opened specifically for that patch so that it's not lost/forgotten about like these ones seem to have been?)

There shouldn't be any more of these, all MSQ dungeons have Duty Support as of 6.5.

These weren't really forgotten about, so much as I was the only one checking and updating them, and I just didn't have time to go through all of them on my own. It's an issue that we currently have timelines/triggers that, in some cases, don't work correctly anymore, which (in my opinion) is a worse case than not having them at all.

xiashtra added a commit that referenced this issue Jun 28, 2024
Continuation of quisquous#5964: removes the remaining outdated
dungeon files for pre-Trust updated dungeons. Several instances still
need to have their triggers/timelines function checked per #150.
github-actions bot pushed a commit that referenced this issue Jun 28, 2024
Continuation of quisquous#5964: removes the remaining outdated
dungeon files for pre-Trust updated dungeons. Several instances still
need to have their triggers/timelines function checked per #150. 173d7b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or change to existing functionality fix-me Bug report validated or feature request planned help wanted No one working on this yet - PRs welcome! oopsy /ui/oopsyraidsy module raidboss /ui/raidboss module
Projects
None yet
Development

No branches or pull requests

2 participants