Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitening bug in CDDetector #4

Open
ablaom opened this issue Jan 11, 2024 · 3 comments
Open

whitening bug in CDDetector #4

ablaom opened this issue Jan 11, 2024 · 3 comments

Comments

@ablaom
Copy link

ablaom commented Jan 11, 2024

using Pkg
Pkg.activate(temp=true)
Pkg.add("MLJBase")
Pkg.add("OutlierDetectionPython")

using MLJBase, OutlierDetectionPython

X = (a = rand(10), b = rand(10))
detector = OutlierDetectionPython.CDDetector()

mach = machine(detector, X)
fit!(mach)

# [ Info: Training machine(CDDetector(whitening = true, …), …).
# ┌ Error: Problem fitting the machine machine(CDDetector(whitening = true, …), …).
# └ @ MLJBase ~/.julia/packages/MLJBase/xcS6N/src/machines.jl:683
# [ Info: Running type checks...
# [ Info: Type checks okay.
# ERROR: Python: TypeError: CD.__init__() got an unexpected keyword argument 'whitening'
# Python stacktrace: none
# Stacktrace:
#   [1] pythrow()
#     @ PythonCall ~/.julia/packages/PythonCall/wXfah/src/err.jl:94
(jl_gWxT0t) pkg> st
Status `/private/var/folders/4n/gvbmlhdc8xj973001s6vdyw00000gq/T/jl_gWxT0t/Project.toml`
  [a7f614a8] MLJBase v1.1.0
  [2449c660] OutlierDetectionPython v0.2.2

FYI: You can add generic interface tests using MLJTestInterface.jl, along the lines of this example. These tests would have caught this error.

@davnn
Copy link
Member

davnn commented Jan 14, 2024

Looks like I forgot to add this detector to the tests (https://github.com/OutlierDetectionJL/OutlierDetectionPython.jl/blob/master/test/runtests.jl). I'll have a look.

@ablaom
Copy link
Author

ablaom commented May 9, 2024

Any progress here?

1 similar comment
@ablaom
Copy link
Author

ablaom commented Dec 20, 2024

Any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants