Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad load_path for COFDetector #6

Closed
ablaom opened this issue Jan 15, 2024 · 3 comments
Closed

Bad load_path for COFDetector #6

ablaom opened this issue Jan 15, 2024 · 3 comments

Comments

@ablaom
Copy link

ablaom commented Jan 15, 2024

julia> MLJModelInterface.load_path(COFDetector)
"COFDetector"

This should be "OutlierDetectorNeighbors.COFDetector".

@ablaom
Copy link
Author

ablaom commented Jan 15, 2024

Okay, it looks like they are all wrong:

julia> eval.(OutlierDetectionNeighbors.MODELS)
5-element Vector{DataType}:
 ABODDetector
 COFDetector
 DNNDetector
 KNNDetector
 LOFDetector

julia> 

julia> load_path.(ans)
5-element Vector{String}:
 "ABODDetector"
 "COFDetector"
 "DNNDetector"
 "KNNDetector"
 "LOFDetector"

@ablaom
Copy link
Author

ablaom commented Jan 15, 2024

Okay, I see why this was not caught before. The bug is that the string returned by load_path currently depends on the namespace. If instead of using OutlierDectectionNeigbors (what I did above) you do import OutlierDetectionNeighbors, the you get:

julia> load_path(OutlierDetectionNeighbors.COFDetector)
"OutlierDetectionNeighbors.COFDetector"

@ablaom
Copy link
Author

ablaom commented Jan 15, 2024

Closed in favor of OutlierDetectionJL/OutlierDetectionInterface.jl#7

@ablaom ablaom closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant