diff --git a/cran-comments.md b/cran-comments.md index 66299fc1..a3c1cd59 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,7 +1,7 @@ Description =============================================== -This submission is primarily to address a recent change in the REDCap server. +This submission is primarily to address a change in the REDCap server. A lot of packages additions in the meantime were building up. Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN. -Will Beasley @@ -11,10 +11,10 @@ Test environments 1. Local Ubuntu, R 4.2.2 2. Local Win11, R 4.3.1 patched 3. R-hub - 1. [Ubuntu Linux, R-release, GCC](https://builder.r-hub.io/status/REDCapR_1.1.9005.tar.gz-ca31dc0eef2e4d6f82ea439a64125d94) - 2. [Fedora Linux, R-devel, clang, gfortran](https://builder.r-hub.io/status/REDCapR_1.1.9005.tar.gz-04e47bc289634445aeafd374a16db8d3) - 3. [Windows Server](https://builder.r-hub.io/status/REDCapR_1.1.9005.tar.gz-a8833d5bd66847c38c3890470eb2d97a) -4. [win-builder](https://win-builder.r-project.org/BS3KTA59FLDi/), development version. + 1. [Ubuntu Linux, R-release, GCC](https://builder.r-hub.io/status/REDCapR_1.1.9005.tar.gz-746e237d11914129b4410114fbfa2c83) + 2. [Fedora Linux, R-devel, clang, gfortran](https://builder.r-hub.io/status/REDCapR_1.1.9005.tar.gz-e695d8a48601419e8059863cc80964b7) + 3. [Windows Server](https://builder.r-hub.io/status/REDCapR_1.1.9005.tar.gz-c30d344462dc43a4b03e68a33be664d9) +4. [win-builder](https://win-builder.r-project.org/0u5J1JiksFZg/), development version. 5. [GiHub Actions](https://github.com/OuhscBbmc/REDCapR/actions), Ubuntu 22.04 LTS R CMD check results @@ -43,8 +43,11 @@ R CMD check results Downstream dependencies ----------------------------------------------- -Packages that depend/import/suggest REDCapR pass checks with `revdepcheck::revdep_check()`. -I talked to the tidyREDCap developer last month, and he says the problem is unrelated to REDCapR. +With one exception, +packages that depend/import/suggest REDCapR pass checks with `revdepcheck::revdep_check()`. + +I worked with **tidyREDCap** team and they accepted a PR that fixes the problem: +. package | E | W | N ------- | - | - | - diff --git a/revdep/README.md b/revdep/README.md index 22a8cf49..71226c7c 100644 --- a/revdep/README.md +++ b/revdep/README.md @@ -10,7 +10,7 @@ |collate |English_United States.utf8 | |ctype |English_United States.utf8 | |tz |America/Chicago | -|date |2023-07-11 | +|date |2023-07-14 | |rstudio |2023.06.1+524 Mountain Hydrangea (desktop) | |pandoc |3.1.5 @ C:\PROGRA~1\Pandoc\pandoc.exe | diff --git a/utility/refresh.R b/utility/refresh.R index 4d883e2c..3b8da506 100644 --- a/utility/refresh.R +++ b/utility/refresh.R @@ -4,8 +4,6 @@ options(device = deviceType) #https://support.rstudio.org/help/discussions/probl spelling::spell_check_package() # spelling::update_wordlist() -lintr::lint_package() -# lintr::lint("R/redcap-metadata-coltypes.R") urlchecker::url_check(); urlchecker::url_update() devtools::document() @@ -13,6 +11,8 @@ devtools::check_man() #Should return NULL devtools::clean_vignettes() devtools::build_vignettes() +lintr::lint_package() +# lintr::lint("R/redcap-metadata-coltypes.R") checks_to_exclude <- c( "covr", "cyclocomp", @@ -29,6 +29,8 @@ goodpractice::results(gp) gp # If necessary: tinytex::tlmgr_install("makeindex") BiocCheck::BiocCheck() +# styler::style_pkg() +# styler::style_file("R/redcap-read-oneshot.R") devtools::document() pkgdown::clean_site() @@ -40,10 +42,9 @@ devtools::run_examples(); #dev.off() #This overwrites the NAMESPACE file too # devtools::run_examples(, "redcap_read.Rd") # pkgload::load_all() test_results_checked <- devtools::test() -test_results_checked <- devtools::test(filter = "read-batch-survey") test_results_checked <- devtools::test(filter = "^validate") -withr::local_envvar(ONLYREADTESTS = "true") -test_results_checked <- devtools::test(filter = "write-batch") +# withr::local_envvar(ONLYREADTESTS = "true") +# test_results_checked <- devtools::test(filter = "write-batch") # testthat::test_dir("./tests/") test_results_not_checked <- testthat::test_dir("./tests/manual/") @@ -55,6 +56,7 @@ devtools::check( # Equivalent of R-hub remote = TRUE, incoming = TRUE ) +rhub::list_validated_emails(); # rhub::validate_email() rhub::check_for_cran(email="wibeasley@hotmail.com") # devtools::check_win_devel() # CRAN submission policies encourage the development version # revdepcheck::revdep_check(num_workers = 4)