Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orleans 8.0 compatibility #43

Open
jaredthirsk opened this issue Jan 8, 2024 · 10 comments
Open

Orleans 8.0 compatibility #43

jaredthirsk opened this issue Jan 8, 2024 · 10 comments

Comments

@jaredthirsk
Copy link

AddRedisGrainStorage exception:

System.TypeLoadException: 'Could not load type 'Orleans.Runtime.KeyedServiceExtensions' from assembly 'Orleans.Core, Version=8.0.0.0, Culture=neutral, PublicKeyToken=null'.'
@hendrikdevloed
Copy link

hendrikdevloed commented Jan 10, 2024

I had the exact same error in my project.

My attempt at migration is in #44
Tests were run and are green.
In my Orleans application, a local .csproj was added instead of the Nuget package and now successfully works on NET8.

However, I have no experience contributing to the Orleans project nor how to update the Nuget bookkeeping. I bumped the package to 8.0.0 and SDK version to 8.0.100.
Please give me some hints or fork and add the missing parts to make this into a proper Nuget update to v8.

@scalalang2
Copy link

any update?

@ReubenBond
Copy link
Contributor

If you create a PR, I will help with the release process

@FabianNet
Copy link

upgrade to .net 8 would be super ;)

@kzu
Copy link

kzu commented Jun 14, 2024

I got this error too, and it was because bumping to Orleans 8.x (in my case) also required bumping the project to .net8. That fixed the issue.

@urumo
Copy link

urumo commented Nov 7, 2024

Honestly this seems like a must have at this point in time. What exactly needs to be done to make this package compatible with Orleans 8 and .Net 8?

@code-maid
Copy link

You are seriously????
ZERO Support about this library
Why did you even take up this case if you are not able to provide proper support, why there are links to your repositories in the official documentation, I just can't understand.. can't understand
Why are you publishing under the Orleans prefix. and you're not doing your job.
Of course, I understand that this is also a question for Orleans dev, but I do not understand.....

@rkargMsft
Copy link

(I'm not on the Orleans team)
Microsoft.* packages are the ones that are maintained by Microsoft.

OrleansContrib are community contributions that are maintained by the community and not directly by Microsoft.

There's actually Redis support in the core Microsoft packages now which seems to have addressed the needs of other .NET 8+ users:
#44 (comment)
Does that work for your scenario? If there are any gaps then it would be good to get issues lodged against those implementations instead of trying to maintain two separate implementations.

Source: https://github.com/dotnet/orleans/tree/main/src/Redis
Example Package: https://www.nuget.org/packages/Microsoft.Orleans.Clustering.Redis

Perhaps the ReadMe for this repository should be updated to prominently call out that it's been replaced by the in-box packages?

@galvesribeiro
Copy link
Member

You are seriously???? ZERO Support about this library Why did you even take up this case if you are not able to provide proper support, why there are links to your repositories in the official documentation, I just can't understand.. can't understand Why are you publishing under the Orleans prefix. and you're not doing your job. Of course, I understand that this is also a question for Orleans dev, but I do not understand.....

@code-maid please lets stop.

First of all, as any OSS project under the MIT license (like this one), there are no warranties, support or guarantees. The code is provided as is.

Secondly, as @rkargMsft just mentioned, this is not the main Orleans repository. This whole organization is about contrib projects. If you don't know what it mean, I would suggest you have a look on your favorite search engine but in a nutshell, it means that outside of the main project it relates to, the community makes extensions which are not maintained by the main repository and its contributors. Many projects from this organization eventually may or may not be integrated with the main repository (like many did) but there are no obligations.

The fact that the main documentation references this organization doesn't make it an official package on any matter. The fact it has the name Orleans also doesn't meant anything. It could be called "banana.Redis" and would be the same. It is just that people name the projects here as what it relates to.

That being said, it is always good to treat people (specially those that we are not paying for) in a healthy way.

The project is open source. The problem on this issue is cause by outdated packages. Literally ANYONE with a GitHub account can make a PR with the updated packages and the maintainers will consider and eventually provide feedback or merge it.

Contributions are always Wellcome.

@code-maid
Copy link

You are seriously???? ZERO Support about this library Why did you even take up this case if you are not able to provide proper support, why there are links to your repositories in the official documentation, I just can't understand.. can't understand Why are you publishing under the Orleans prefix. and you're not doing your job. Of course, I understand that this is also a question for Orleans dev, but I do not understand.....

@code-maid please lets stop.

First of all, as any OSS project under the MIT license (like this one), there are no warranties, support or guarantees. The code is provided as is.

Secondly, as @rkargMsft just mentioned, this is not the main Orleans repository. This whole organization is about contrib projects. If you don't know what it mean, I would suggest you have a look on your favorite search engine but in a nutshell, it means that outside of the main project it relates to, the community makes extensions which are not maintained by the main repository and its contributors. Many projects from this organization eventually may or may not be integrated with the main repository (like many did) but there are no obligations.

The fact that the main documentation references this organization doesn't make it an official package on any matter. The fact it has the name Orleans also doesn't meant anything. It could be called "banana.Redis" and would be the same. It is just that people name the projects here as what it relates to.

That being said, it is always good to treat people (specially those that we are not paying for) in a healthy way.

The project is open source. The problem on this issue is cause by outdated packages. Literally ANYONE with a GitHub account can make a PR with the updated packages and the maintainers will consider and eventually provide feedback or merge it.

Contributions are always Wellcome.

Thanks for the outrage!!!
I was misled by a package with the prefix Orleans.*
I apologize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants