Potential bug

[pderouen]

origen_testers/lib/origen_testers/smartest_based_tester/base/limits_file.rb

Lines 19 to 41 in 05824ce

	def header
	if smt8?
	@test_path = []
	l = 'Test Suite,Test,Test Number,Test Text'
	if test_modes.empty?
	l += ',Low Limit,High Limit'
	else
	l += ',Low Limit'
	(test_modes.size - 1).times { l += ',' }
	l += ',High Limit'
	(test_modes.size - 1).times { l += ',' }
	end
	l += ',Unit,Soft Bin'
	lines << l
	l = ',,,'
	if test_modes.empty?
	l += ',default,default'
	else
	test_modes.each { |mode| l += ",#{mode}" }
	test_modes.each { |mode| l += ",#{mode}" }
	end
	lines << l

The new lint rules want the loops on line 38 and 39 combined into 1 loop. I am going to disable the check to leave the code as is. But, wanted to raise it as a potential bug. Is the duplication intended?

[priyavadan]

seems like an oversight, should only need 1 of them , imo.