rspec crash on test failure

[pderouen]

Rspec crashes when a test fails. Commenting out this line prevents the crash and doesn't appear to affect functionality at all

origen_app_generators/spec/spec_helper.rb

Line 23 in 5ba9d89

require "rspec/legacy_formatters"

[info-rchitect]

@pderouen We shouldn't need legacy formatters, I removed this line in all of my apps. Everyone else agree?

[pderouen]

It sure seems like it's not necessary. But, I don't know what it's use would be. Unless there's a need to investigate further, I will submit a pull request to remove legacy formatters so that new apps don't start their life with runtime errors when a spec test fails.

[redxeth]

Hi all-- am seeing this also in my latest PR on origentesters. Should we comment it out in spec_helper.rb ?

[redxeth]

Tried doing what is being done in origen core here, which works fine when running origen specs with a forced failure (fails without crash). But can't run a specific spec now with rspec (e.g. rspec spec/atp/flow_spec.rb) as it doesn't recognize RSpec::Version. Nice to be able to run rspec on individual files when debugging things.

[priyavadan]

# require "rspec/legacy_formatters"
require 'rspec/expectations'
extend RSpec::Matchers
require "#{Origen.top}/spec/format/origen_formatter"

This is probably what needs to happen for things to play nicely with the latest Rspec, can you give it a try @redxeth

[redxeth]

Actually figured out that :

require "rspec/legacy_formatters" if Gem::Version.new(RSpec::Core::Version::STRING) < Gem::Version.new('3.0.0')

works great!

Origen core must be loading rspec but most apps don't (they load rspec_core directly?).

[redxeth]

@pderouen should we test out my fix on another app before deciding to PR the app generator and update it to support?