Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new maven rules #4

Open
wants to merge 82 commits into
base: feature/use-new-maven-rules
Choose a base branch
from
Open

Use new maven rules #4

wants to merge 82 commits into from

Conversation

steve-hb
Copy link
Contributor

@steve-hb steve-hb commented Sep 12, 2019

Hey,

I'm back from my business trip. This & next week I'm going to try migrating one of our large projects to Bazel using this plugin. If everything works fine, I'll write a comment below, otherwise I submit a patch or start a discussion.

#1

@steve-hb
Copy link
Contributor Author

steve-hb commented Sep 13, 2019

Today I tried it the first time:

  • 1. I think I'll implement an option to provide custom templates (I'm using wrapper rules for some things).
  • 2. The plugin identifies some of the modules as external maven dependencies. It's clear that this won't work.
  • 3. We should use glob(["src/main/java/**/*.java"]) instead of writing hundreds of lines.
  • 4. Modules only containing resources are not handled correctly: The Build files are empty
  • 5. Local modules specified as dependencies are not resolved correctly: //:module_name won't work for modules located at //moduleGroup/group1/module_name .
    This could be solved by defining the complete path in every dependency or by providing aliases/wrappers in our root BUILD file.
  • 6. The rule-names are too complex and long: We should provide options to use custom formats. (e.g. <fomat>%artifactId%</format> <fomat>%groupId_%artifactId%</format>

Next week (Tuesday or later) I'm looking forward to evaluate these things and maybe create Issues for them or implement them directly in this PR. @OrhanKupusoglu What do u think? New issues or not?

@OrhanKupusoglu
Copy link
Owner

New issues = too much bureaucracy
I think you can implement them in this PR with atomic commits (one and only one thing at a time)

@steve-hb
Copy link
Contributor Author

steve-hb commented Sep 18, 2019

New issues = too much bureaucracy

I'm a German - we know how bureaucracy works! :P

I started implementing all the things, but it will take about a week. I'm currently a little bit too busy.

// A week... nope. Too busy currently, will continue next months, maybe 2020

@OrhanKupusoglu
Copy link
Owner

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants