Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging level to be set through the environment #2

Open
mattbaron opened this issue Jul 22, 2022 · 1 comment
Open

Allow logging level to be set through the environment #2

mattbaron opened this issue Jul 22, 2022 · 1 comment

Comments

@mattbaron
Copy link

I will be submitting a PR for this.

@mattbaron mattbaron changed the title Allow logger level to be set through the environment Allow logging level to be set through the environment Jul 22, 2022
@mattbaron
Copy link
Author

@Esity I'm waffling a little bit on how to do this, partly because the default behavior in regard to the logging level varies a little bit.

If Telemetry::Logger::setup is called, the default level is info, although it can be customized through the setup call. If Telemetry::Logger::setup isn't called, the default logging level is debug. Is this by design? Can that be changed to be a uniform default regardless of scenario? Or would you rather keep the functionality as-is? I want to add this ENV variable functionality while being careful of not changing the behavior too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant