Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 4.x support #30

Open
caldwell opened this issue Oct 17, 2015 · 0 comments
Open

Node 4.x support #30

caldwell opened this issue Oct 17, 2015 · 0 comments

Comments

@caldwell
Copy link
Contributor

I installed node 4.1.1 (4.2.1 is just entering Debian, now) and I'm getting a bunch of errors while compiling:

  CXX(target) Release/obj.target/navcodec/src/navcodec.o
In file included from ../src/navformat.h:25:0,
                 from ../src/navcodec.h:22,
                 from ../src/navcodec.cpp:22:
../src/navstream.h:35:36: error: expected class-name before ‘{’ token
 class NAVStream : node::ObjectWrap {
                                    ^
../src/navstream.h:47:34: error: ‘Arguments’ does not name a type
   static Handle<Value> New(const Arguments& args);
                                  ^
In file included from ../src/navcodec.h:22:0,
                 from ../src/navcodec.cpp:22:
../src/navformat.h:37:36: error: expected class-name before ‘{’ token
 class NAVFormat : node::ObjectWrap {
                                    ^
../src/navformat.h:51:34: error: ‘Arguments’ does not name a type
   static Handle<Value> New(const Arguments& args);
                                  ^
../src/navformat.h:54:38: error: ‘Arguments’ does not name a type
   static Handle<Value> Version(const Arguments& args);
                                      ^
../src/navformat.h:55:37: error: ‘Arguments’ does not name a type
   static Handle<Value> Decode(const Arguments& args);
                                     ^
../src/navformat.h:56:35: error: ‘Arguments’ does not name a type
   static Handle<Value> Dump(const Arguments& args);
                                   ^
../src/navformat.h:64:42: error: expected class-name before ‘{’ token
 class DecoderNotifier : node::ObjectWrap {
                                          ^
../src/navformat.h:77:35: error: ‘Arguments’ does not name a type
   static Handle<Value> Done(const Arguments& args);
                                   ^
In file included from ../src/navcodec.h:23:0,
                 from ../src/navcodec.cpp:22:
../src/navcodeccontext.h:36:20: error: ‘AccessorInfo’ does not name a type
              const AccessorInfo& info);
                    ^
../src/navcodeccontext.h:38:42: error: expected class-name before ‘{’ token
 class NAVCodecContext : node::ObjectWrap {
                                          ^

There are more, too, but they're all along the same lines. I assume this is because of the V8 changes in the newest node (from the io.js merger). Are there any plans to support the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant