This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
Add available scheme to CodeSchool url #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apex-omontgomery
suggested changes
Nov 9, 2018
| before_create :set_valid_scheme, :if => Proc.new{ |cs| URI(cs.url).scheme.nil? } | ||
|
|
||
| private | ||
|
|
There was a problem hiding this comment.
Would you please correct the linter errors.
https://travis-ci.org/OperationCode/operationcode_backend/builds/452053452#L838
|
|
||
| private | ||
|
|
||
| def set_valid_scheme |
There was a problem hiding this comment.
Would you be able to add a unit test showing what happens in these cases:
- Correct url
- Incorrect url with https being the valid route
- Incorrect url with http being the valid route
Thank you!
|
Thanks for the PR. If this is your first PR with us please fill this form out and ashley will send you some stickers and a handwritten letter. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Before saving CodeSchool to the database, it takes the following steps:
httpin url without protocolhttpshttpsis not available, then change protocol tohttpThe http call slows down saving to the database. It can be avoided by using only the http protocol.
This is my first commit to an open source project, so please tell me what I am doing wrong if you can 😊
Issue Resolved
Fixes #436