From 4803bde977cbbdeb500f0fdcced7b83c3ad669e6 Mon Sep 17 00:00:00 2001 From: Jamey Huffnagle Date: Fri, 16 Feb 2024 07:21:01 -0500 Subject: [PATCH] feedback and docstrings --- app/src/molecules/BackgroundOverlay/index.tsx | 6 +----- app/src/molecules/LegacyModal/LegacyModalShell.tsx | 4 ---- app/src/molecules/LegacyModal/index.tsx | 3 +++ app/src/molecules/Modal/Modal.tsx | 3 +++ components/src/modals/ModalShell.tsx | 7 ++----- 5 files changed, 9 insertions(+), 14 deletions(-) diff --git a/app/src/molecules/BackgroundOverlay/index.tsx b/app/src/molecules/BackgroundOverlay/index.tsx index 24d2f630b4d..94cd6e67f81 100644 --- a/app/src/molecules/BackgroundOverlay/index.tsx +++ b/app/src/molecules/BackgroundOverlay/index.tsx @@ -12,11 +12,7 @@ const BACKGROUND_OVERLAY_STYLE = css` position: ${POSITION_FIXED}; inset: 0; z-index: 3; - background-color: ${COLORS.black90}${COLORS.opacity40HexCode}; - - @media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} { - background-color: ${COLORS.black90}${COLORS.opacity60HexCode}; - } + background-color: ${COLORS.black90}${COLORS.opacity60HexCode}; ` export interface BackgroundOverlayProps diff --git a/app/src/molecules/LegacyModal/LegacyModalShell.tsx b/app/src/molecules/LegacyModal/LegacyModalShell.tsx index 13d009b7ea7..f8b7ea89121 100644 --- a/app/src/molecules/LegacyModal/LegacyModalShell.tsx +++ b/app/src/molecules/LegacyModal/LegacyModalShell.tsx @@ -84,10 +84,6 @@ const Overlay = styled.div` z-index: 1; background-color: ${COLORS.black90}${COLORS.opacity40HexCode}; cursor: default; - - @media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} { - background-color: ${COLORS.black90}${COLORS.opacity60HexCode}; - } ` const ContentArea = styled.div<{ zIndex: string | number }>` display: flex; diff --git a/app/src/molecules/LegacyModal/index.tsx b/app/src/molecules/LegacyModal/index.tsx index b6e9b514093..03c9dd1d72f 100644 --- a/app/src/molecules/LegacyModal/index.tsx +++ b/app/src/molecules/LegacyModal/index.tsx @@ -19,6 +19,9 @@ export interface LegacyModalProps extends StyleProps { footer?: React.ReactNode } +/** + * For Desktop app use only. + */ export const LegacyModal = (props: LegacyModalProps): JSX.Element => { const { type = 'info', diff --git a/app/src/molecules/Modal/Modal.tsx b/app/src/molecules/Modal/Modal.tsx index 4b5b5ad39ea..3b8ec0464fd 100644 --- a/app/src/molecules/Modal/Modal.tsx +++ b/app/src/molecules/Modal/Modal.tsx @@ -24,6 +24,9 @@ interface ModalProps extends StyleProps { /** see ModalHeader component for more details */ header?: ModalHeaderBaseProps } +/** + * For ODD use only. + */ export function Modal(props: ModalProps): JSX.Element { const { modalSize = 'medium', diff --git a/components/src/modals/ModalShell.tsx b/components/src/modals/ModalShell.tsx index 8954b2301fa..5aa688f7402 100644 --- a/components/src/modals/ModalShell.tsx +++ b/components/src/modals/ModalShell.tsx @@ -78,13 +78,10 @@ const Overlay = styled.div` top: 0; bottom: 0; z-index: 1; - background-color: ${COLORS.black90}${COLORS.opacity40HexCode}; + background-color: ${COLORS.black90}${COLORS.opacity60HexCode}; cursor: default; - - @media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} { - background-color: ${COLORS.black90}${COLORS.opacity60HexCode}; - } ` + const ContentArea = styled.div<{ zIndex: string | number }>` display: flex; position: ${POSITION_ABSOLUTE};