Sample app that builds and makes a simple http call #242
Replies: 7 comments 3 replies
-
Nice sample! A few suggestions:
|
Beta Was this translation helpful? Give feedback.
-
My sample came from The official Ovos sample
…On Mon, Mar 4, 2024 at 2:06 PM Mike ***@***.***> wrote:
Nice sample! A few suggestions:
1. create_skill is no longer required under OVOS, so you can
completely remove that function
2. I'd recommend switching to ovos-lingua-franca
<https://github.com/OpenVoiceOS/ovos-lingua-franca> instead of
lingua-franca, as the latter hasn't been updated for a long time and
frequently causes dependency conflicts in OVOS
3. Your *init* method isn't passing *args, **kwargs, which will
eventually cause load issues in OVOS. You'll want something like def
__init__( self, *args, **kwargs ), which should also be done in your
OVOSSkill call on the next line of code
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABS6UT4Q4RLJ3DNOS4COVLTYWTV55AVCNFSM6AAAAABEEROXL6VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4DMNZSGQZDI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
https://github.com/OpenVoiceOS/skill-ovos-hello-world/blob/42bee014eebbd251e874a1fdb4e9766086e83c18/__init__.py#L15 The official sample does not import lingua-franca, nor does it have a |
Beta Was this translation helpful? Give feedback.
-
Where is handle_tv_control_jump called? Is it in your mycroft.conf or a different file? |
Beta Was this translation helpful? Give feedback.
-
Different file. But it just makes a similar HTTP call.
…On Tue, Mar 5, 2024 at 9:57 PM Michelle Tran ***@***.***> wrote:
Where is handle_tv_control_jump called? Is it in your mycroft.conf or a
different file?
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABS6UT5NMOGGXRM6M6KI53TYW2V6BAVCNFSM6AAAAABEEROXL6VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4DMOBYHEYTK>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
my sample doesnt emit a custom message. it just makes http call
…On Wed, Mar 6, 2024 at 7:27 AM Michelle Tran ***@***.***> wrote:
Were you able to confirm whether the bus emitted a message after you said
your set command for this skill? I'm having trouble connecting my emitted
message to my skill.
—
Reply to this email directly, view it on GitHub
<#242 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABS6UT6GK6U3UILEP77Q7ULYW4YXVAVCNFSM6AAAAABEEROXL6VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4DMOJVGQ2TK>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
here you go
gary-roku-tv-skill.zip
Beta Was this translation helpful? Give feedback.
All reactions