Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support github sync main branch #1781

Open
jeiea opened this issue Dec 4, 2020 · 1 comment
Open

Support github sync main branch #1781

jeiea opened this issue Dec 4, 2020 · 1 comment
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. DOC Pertains inclusively to the Documentation operations. security Usually relates to something critical. UI Pertains inclusively to the User Interface.
Milestone

Comments

@jeiea
Copy link

jeiea commented Dec 4, 2020

Github adopted main as default branch name. But it seems to cause 403 with the openuserjs github webhook sync feature.
How about supporting it?

@Martii
Copy link
Member

Martii commented Dec 5, 2020

Ref(s): (might be added to)

Always cite when a change comes through like this.

This topic will be locked as I really don't want a P.C. debate here as it's not the focus of OUJS... however it will be continually considered provided the integrity of the site isn't compromised including all default upstream and downstream observations.

This would be a breaking change.


$ mkdir repotest
$ cd repotest/
$ git init
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint:   git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint: 
hint:   git branch -m <name>
$ git --version
git version 2.32.0
$ date
Fri 18 Jun 2021 06:48:27 PM EDT

Ref(s):

@OpenUserJS OpenUserJS locked as too heated and limited conversation to collaborators Dec 5, 2020
@Martii Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. security Usually relates to something critical. UI Pertains inclusively to the User Interface. labels Dec 5, 2020
@Martii Martii added this to the #1705 milestone Apr 11, 2021
@Martii Martii added the DOC Pertains inclusively to the Documentation operations. label Apr 11, 2021
phw added a commit to phw/OpenUserJS.org that referenced this issue Oct 16, 2021
This allows the webhook to work independent of the name of the default branch on Github (which used to be master, but is now main and can be renamed by the repository owner).

Fixes OpenUserJS#1781
phw added a commit to phw/OpenUserJS.org that referenced this issue Oct 16, 2021
This allows the webhook to work independent of the name of the default branch on Github (which used to be master, but is now main and can be renamed by the repository owner).

Fixes OpenUserJS#1781
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. DOC Pertains inclusively to the Documentation operations. security Usually relates to something critical. UI Pertains inclusively to the User Interface.
Development

Successfully merging a pull request may close this issue.

2 participants