Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motor code should include a bit (or packet count) that indicates it is receiving packets from the display... #122

Open
geeksville opened this issue Oct 3, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@geeksville
Copy link

geeksville commented Oct 3, 2019

From a discussion with @r0mko:

yes, if the tx line from your display to the rx line of the motor was broken I think that might explain it. and if it does, it would be great to put in an issue for the motor code to include a status bit in one of the packets it sends to the display that says 'is receiving packets from the display' - so we can detect this fault and tell the user ;-)

Does anything like this already exist? If not it would be a great easy addition to the motor side so we could tell the user if we think there is a broken wire from the display to the motor.

If someone adds this, please pass this bug back to me and I promise to add display code to check for this bit ;-)

@geeksville geeksville added the enhancement New feature or request label Oct 3, 2019
@casainho
Copy link
Contributor

casainho commented Oct 3, 2019

Good idea. Even we need more, we need to separate configuration packets from regular packets, because configuration data will increase a lot with the points for the torque sensor calibration.

@PrivatePuffin
Copy link
Member

Note:
It would be prefered to only do these calculations in something like a dev-mode...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants