Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging multiple .ptu files to a single hdf5 #34

Open
Mattyboi123 opened this issue Nov 20, 2019 · 10 comments
Open

merging multiple .ptu files to a single hdf5 #34

Mattyboi123 opened this issue Nov 20, 2019 · 10 comments

Comments

@Mattyboi123
Copy link

Apologies if this is an already answered question or I've missed something obvious but how does one combine multiple .ptu files into a single hdf5 file prior to further analysis withe pycorrelate or fretbursts?

Best
Matt

@mayeshh
Copy link

mayeshh commented Dec 20, 2019

I suggest keeping your files separate and loading the data into one large DataFrame. For example bursts_all = pd.concat(dataframe_list, ignore_index=True) .

@Mattyboi123
Copy link
Author

hi thanks for the suggestion but will that preserve all of the nanotimes and still be navigable using the normal fretbursts commands?

@Mattyboi123
Copy link
Author

by the by did you sole the issue you were having with no module named phrates_c? I now have the same issue trying to import FRETbursts on a new clean anaconda install on a new machine perhaps it is a python 3.8 issue as when Itried to install fretbursts through conda-forge it said something about that and didn't install so Icloned my version that was working on another machine (python 3.7) then this issue on the new machine

@mayeshh
Copy link

mayeshh commented Dec 12, 2020

hi thanks for the suggestion but will that preserve all of the nanotimes and still be navigable using the normal fretbursts commands?

Yes, each data object will have the same fields and FRETBursts will work on them in the same way.

@mayeshh
Copy link

mayeshh commented Dec 12, 2020

by the by did you sole the issue you were having with no module named phrates_c? I now have the same issue trying to import FRETbursts on a new clean anaconda install on a new machine perhaps it is a python 3.8 issue as when Itried to install fretbursts through conda-forge it said something about that and didn't install so Icloned my version that was working on another machine (python 3.7) then this issue on the new machine

I haven't upgraded to python 3.8, so I don't have experience with the compatibility. I would not expect this to be the issue, rather updates in the dependencies could cause issues (e.g. deprecations in numpy).

Please try an “editable” installation:

git clone https://github.com/OpenSMFS/FRETBursts.git
cd FRETBursts
pip install -e .

@Mattyboi123
Copy link
Author

Mattyboi123 commented Dec 12, 2020 via email

@mayeshh
Copy link

mayeshh commented Dec 12, 2020

Ye I did try installing like that, it didn't help. In the end I just checked commented out the line in phrates.py that called for phrates_c. Then another line about normpdf in matplot lib bad something else which I forget now and it works fine on 3.8.

Yes, the phrates_c module is a C optimized version of phrates, so it is faster but not necessary for FRETBursts to work.

For the deprecation warning in matplotlib, I have submitted a PR for the normpdf issue but I haven't been able to figure out why it fails the CI checks so it has not been merged to the master branch.

Could you print a list of your dependencies and versions for reference?

@Mattyboi123
Copy link
Author

Mattyboi123 commented Dec 12, 2020 via email

@Mattyboi123
Copy link
Author

Hello, I still have this issue with cython scritpts not being found when runing FRETbursts even in the dedicated envoronment you suggested and after installing build tools for virtual studio. It just says 'no module named phrates_c' Can you tell me if you are running on a windows machine, how your cython extension scripts/modules are being compiled?

@Mattyboi123
Copy link
Author

I was able to get it to work now in the manner you suggetsed - there was a path issue becuasue I was opening scripts from Spyder that were in a different folder. creating local copies within the FRETbursts dedicated environment and opening those worked perfectly with the only caveat I've yet found being that the normPPDF from matplotlib needed to be commented out - whihc as Iunderstand it hads been worked around easily.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants