Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] invalid Contact passes validation #3510

Open
nevian427 opened this issue Nov 9, 2024 · 2 comments
Open

[BUG] invalid Contact passes validation #3510

nevian427 opened this issue Nov 9, 2024 · 2 comments

Comments

@nevian427
Copy link

nevian427 commented Nov 9, 2024

OpenSIPS version you are running

version: opensips 3.4.2 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, HP_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 8a6e78dde
main.c compiled on 07:12:46 Oct 19 2023 with gcc 8

Describe the bug

REGISTER sip:10.27.136.168:5060;transport=UDP SIP/2.0
Via: SIP/2.0/UDP 10.36.51.108:5060;branch=z9hG4bK-3424508-342-0
From: User000341 <sip:[email protected]>;tag=3424508SIPpTag07342
To: User000341 <sip:[email protected]>
Call-ID: [email protected]
CSeq: 1 REGISTER
Contact: <sip:User000341@:;transport=UDP>
Max-Forwards: 68
Content-Length: 0
Expires: 12000
Allow: INVITE, ACK, BYE, CANCEL, INFO, OPTIONS, UPDATE
Supported:
User-Agent: sipAgentServer

For some reason this obviously broken Contact not get reported by

   $var(err_id) = sipmsg_validate("shmrftc");
    if ($var(err_id) < 0) {
        xlog("L_INFO", "pt=[$time(%b %d %T):$Tsm], [VALIDATE] node=[lb1]. Invalid SIP request: [$var(err_id)] (M=$rm ID=$ci RU=$ru F=$fu T=$tu CS=$cs SRC=$socket_in(proto):$si:$sp DST=$du)\n");
        send_reply(400, "Invalid SIP request");
        exit;
    }

To Reproduce

Expected behavior

We expect 400 responce to this message. In reality this gets reported only at save time in log

Relevant System Logs

OS/environment information

  • Operating System: RedHat 8
  • OpenSIPS installation: RPM from official repo
  • other relevant information:

Additional context

Copy link

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@github-actions github-actions bot added the stale label Nov 26, 2024
@nevian427
Copy link
Author

Not fixed yet

@stale stale bot removed the stale label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant