Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra is invalid but is shown as okay #9812

Open
Castavo opened this issue Nov 21, 2024 · 5 comments · May be fixed by #9881
Open

Infra is invalid but is shown as okay #9812

Castavo opened this issue Nov 21, 2024 · 5 comments · May be fixed by #9881
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug

Comments

@Castavo
Copy link
Contributor

Castavo commented Nov 21, 2024

What happened?

Enregistrement.de.l.ecran.2024-11-21.155613.mp4

Infra is shown in green however when trying to add a train, I get an error.

You can use this infrastructure

What did you expect to happen?

I expect the infra state bubble to be red if the infrastructure can't simulate anything

How can we reproduce it (as minimally and precisely as possible)?

  1. Have a broken infrastructure (you can use the one I provided in the description)
  2. Create a scenario with this infrastructure
  3. Witness the infra being loaded in green
  4. Try to create a train
  5. Witness the error

On which environments the bug occurs?

Recette (SNCF)

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

6be0604

@Castavo Castavo added area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug labels Nov 21, 2024
@Castavo
Copy link
Contributor Author

Castavo commented Nov 21, 2024

I created it as a major bug, that might be a little too severe, change if you think it's minor

@Akctarus Akctarus self-assigned this Nov 25, 2024
@Akctarus
Copy link
Contributor

In addition to the red icon, shouldn't there also be a banner to indicate to the user that the infrastructure is broken ? @thibautsailly

@Akctarus Akctarus linked a pull request Nov 27, 2024 that will close this issue
@Castavo
Copy link
Contributor Author

Castavo commented Nov 28, 2024

That's a good idea, I can't remember what we had before TSV2, @clarani do you remember ?

@thibautsailly
Copy link

This is a good idea, but I don't think problems should be detailed in this context. We could link to this infrastructure in the infrastructure editor, with conflicts displayed, from the message.

@Castavo
Copy link
Contributor Author

Castavo commented Nov 28, 2024

@thibautsailly could you expand on the message you speak of ? There is no message at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants