Flaky test_run_conv_model

[Syzygianinfern0]

Description

The test_run_conv_model test is flaky

SyMPC/tests/sympc/module/module_test.py

Line 91 in 95e351d

def test_run_conv_model(get_clients: Callable[[int], List[Any]]):

How to Reproduce

Run the test a bunch of times 😛.

Expected Behavior

The test must pass reliably.

Additional Context

• Fixing the atol parameter is usually sufficient if the values are really close.
• Sometimes, the methods used in the underlying calculations have parameters that trade-off between speed and accuracy of the approximation. Those can be tweaked to give reliable results.

Note: @SyMPC, a reliable test must pass 30 times in a row.

[gmuraru]

Made a PR to unblock development since this test (and some other ones) are creating more failures than normally.
I created a new issue for increasing the tolerance and check which underlying approximations gives bad results