Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): Add socials of user to the pixel #4

Open
JaeAeich opened this issue Aug 14, 2023 · 3 comments
Open

feat(modal): Add socials of user to the pixel #4

JaeAeich opened this issue Aug 14, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JaeAeich
Copy link
Collaborator

Description

Currently the modal only shows the person's name, pfp and message, add their socials like LinkedIn and Github to it.

Expected outcome

Social handles being displayed in the modal of the user.

Proposed solution

Change the data (pixel.ts) schema and add the above-mentioned attribute and then render the same in the modal.

@JaeAeich JaeAeich added enhancement New feature or request good first issue Good for newcomers labels Aug 14, 2023
@Vidhanvyrs
Copy link

hey @JaeAeich I am happy to be assigned to this issue and help here!

@Asp-Codes
Copy link
Contributor

Hello @JaeAeich I would like to contribute by solving the issue from my side.

@JaeAeich
Copy link
Collaborator Author

Ok, sure!, create a PR, since there have been many PRs pixels already, I think its best if you both start working on the solution, as we are short on time, I'd say the PR that comes first will be entertained.

PS: Solution is to add extra social fields namely linkedin and github in the data fields of all the pixels, and then render them in the modal of the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants