Fix the bug where both moving from and to coordinates are the same when moving between differnt cells. #3852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en moving between differnt cells.
$char->{pos} and $char->{pos_to} are both a reference to a hash of
coordinates. They were incorrectly assigned to the same reference inside
skill_used_no_damage() which made them pointing to the same hash. There will
be no more strange routing after this fix.
This has been bothering me for a long time now. I'm happy I finally got
to the bootm of it.
hexhexD
force-pushed
the
move-from-to-fix
branch
from
9fdb53e
to
0124748
Compare
alisonrag
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug:
I tested locally that the refs are now different and everything works great.