-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Bindings (not a bug) #280
Comments
Good job! Someone correct me if I'm wrong but Registration is the process of overlaying the RGB image onto the depth map? |
Cool. Exactly what I've been waiting for. I'll see what ConvNets can do here |
Do you have a plan to get it merged to this repo? Or do you plan to maintain it yourself (and add a mention in the README.md here)? |
Sorry, I haven't had much time to maintain this recently. In the next On Fri, Jan 29, 2016, 4:06 PM Lingzhu Xiang [email protected]
|
FWIW, I also have a python binding (it's private for now) based on cython and also Julia binding r9y9/Libfreenect2.jl (requires development version of julia though). Recently I'm regularly testing with the latest libfreenect2. If anyone interested in python one, I will consider make it public (example code is somthing like this). EDIT: I should have mentioned that I was testing these on osx only. |
Your python example is quite similar but has some small differences in naming and functionalities. pyfreenect2 seems to have an extra layer of python encapsulation around raw interfaces, which yours doesn't have. I think it's best for you two to have consensus and solve the differences. Probably by providing reviews in the potential pull request. There can be only one python wrapper. I took a brief look. "PyFreeNect2" is not consistent with the rest of the naming scheme. "PyFreenect2" or "pyfreenect2" should be used. Also, I see some underscore names. My opinion is to use CamelCase in a consistent way that matches the C++ API as much as possible to minimize confusion. As to the Julia binding, you are welcome to make a pull request. A binding needs documentation, an example, and cross-platform test results to be merged. |
For the record, the SWIG file in #427 should in the future also be able to auto-generate Python bindings. But of course, this requires working out the kinks there first, while we have working bindings here. |
I just made my python binding public under MIT license: https://github.com/r9y9/pylibfreenect2. In pylibfreenect2:
For someone who is interested, the easiest way to use pylibfreenect2 for now is though the examples/multiframe_listener.py. Any comment / issue / PR is welcome. |
So, I wrote some quick (8 hours) Python bindings for libfreenect2, entitled pyfreenect2. If anyone wants to help (I still have no idea what Registration is), have at it.
The text was updated successfully, but these errors were encountered: