Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to cli guide #966

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Edits to cli guide #966

merged 4 commits into from
Oct 18, 2024

Conversation

atravitz
Copy link
Contributor

Edits/suggestions from me reading through these docs as a new user.

Developers certificate of origin

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (83028b1) to head (69f2d0b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   94.59%   92.84%   -1.76%     
==========================================
  Files         134      134              
  Lines        9935     9935              
==========================================
- Hits         9398     9224     -174     
- Misses        537      711     +174     
Flag Coverage Δ
fast-tests 92.84% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks! just a couple of suggestions for issues prior to this PR that could be quickly addressed if we want to

docs/guide/cli/cli_yaml.rst Outdated Show resolved Hide resolved
docs/guide/cli/cli_yaml.rst Show resolved Hide resolved
docs/guide/cli/cli_yaml.rst Outdated Show resolved Hide resolved
docs/guide/cli/cli_yaml.rst Outdated Show resolved Hide resolved
@atravitz atravitz enabled auto-merge October 18, 2024 18:27
@atravitz atravitz merged commit d98f67b into main Oct 18, 2024
11 checks passed
@atravitz atravitz deleted the docs_cli_edits branch October 18, 2024 18:36
@atravitz atravitz linked an issue Nov 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs review: cli
2 participants