Kotlin KSP Nullability Fix #718
Merged
+80
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using nullable types in JPA Entity fields, the type determination code was throwing exceptions. This change creates a local version of the KSType.toClassName() function which gets the ClassName while ignoring the KSType's nullability and parameterization. It also ensures that the ClassName returned does not include a nullability modifier as it previously did with Enums.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some suggestions could not be made:
- pom.xml
- lines 150-150
- lines 304-308
- lines 505-506
- querydsl-examples/pom.xml
- lines 32-31
- querydsl-examples/querydsl-example-jpa-guice/pom.xml
- lines 16-15
- querydsl-examples/querydsl-example-jpa-quarkus/pom.xml
- lines 15-14
- querydsl-examples/querydsl-example-jpa-spring/pom.xml
- lines 12-11
- querydsl-examples/querydsl-example-kotlin-codegen/pom.xml
- lines 11-10
- querydsl-examples/querydsl-example-kotlin-jpa/pom.xml
- lines 11-10
- querydsl-examples/querydsl-example-kotlin-mongodb/pom.xml
- lines 11-10
- querydsl-examples/querydsl-example-r2dbc-sql-codegen/pom.xml
- lines 13-12
- querydsl-examples/querydsl-example-r2dbc-sql-codegen/src/test/java/com/querydsl/example/dao/AbstractDaoTest.java
- lines 5-6
- lines 18-19
- querydsl-examples/querydsl-example-sql-guice/pom.xml
- lines 16-15
- querydsl-examples/querydsl-example-sql-spring/pom.xml
- lines 13-12
- querydsl-libraries/pom.xml
- lines 40-39
- querydsl-libraries/querydsl-collections/pom.xml
- lines 55-54
- querydsl-libraries/querydsl-core/pom.xml
- lines 14-13
- querydsl-libraries/querydsl-guava/pom.xml
- lines 13-12
- querydsl-libraries/querydsl-jpa-spring/pom.xml
- lines 16-15
- querydsl-libraries/querydsl-jpa/pom.xml
- lines 161-160
- querydsl-libraries/querydsl-kotlin/pom.xml
- lines 12-11
- querydsl-libraries/querydsl-mongodb/pom.xml
- lines 74-73
- querydsl-libraries/querydsl-r2dbc/pom.xml
- lines 17-16
- querydsl-libraries/querydsl-scala/pom.xml
- lines 17-16
- querydsl-libraries/querydsl-spatial/pom.xml
- lines 53-52
- querydsl-libraries/querydsl-sql-json/pom.xml
- lines 14-13
- querydsl-libraries/querydsl-sql-spatial/pom.xml
- lines 14-13
- querydsl-libraries/querydsl-sql-spring/pom.xml
- lines 16-15
- querydsl-libraries/querydsl-sql/pom.xml
- lines 17-16
- querydsl-tooling/pom.xml
- lines 25-24
- querydsl-tooling/querydsl-apt/pom.xml
- lines 14-13
- querydsl-tooling/querydsl-codegen-utils/pom.xml
- lines 19-18
- querydsl-tooling/querydsl-codegen/pom.xml
- lines 14-13
- querydsl-tooling/querydsl-jpa-codegen/pom.xml
- lines 14-13
- querydsl-tooling/querydsl-kotlin-codegen/pom.xml
- lines 14-13
- querydsl-tooling/querydsl-ksp-codegen/pom.xml
- lines 55-54
- querydsl-tooling/querydsl-maven-plugin/pom.xml
- lines 18-17
- querydsl-tooling/querydsl-sql-codegen/pom.xml
- lines 17-16
velo
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using nullable types in JPA Entity fields, the type determination code was throwing exceptions. This change creates a local version of the KSType.toClassName() function which gets the ClassName while ignoring the KSType's nullability and parameterization. It also ensures that the ClassName returned does not include a nullability modifier as it previously did with Enums.