Fix AbstractR2DBCQuery Fetch Method #490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Jul 31, 2024
velo
requested changes
Jul 31, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
For now, going to close this as tests are no passing. |
|
@velo Sorry for the late reply. I will upload it again after changing the test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to explicitly cancel R2DBC connection pool
@velo
issue number : #352
background :
This code gets the db connection via
getConnectionand performs operations withinflatMapMany.as-is:
However, there is no explicit connection termination in the current version. There is no code to return to the connection pool, which can result in a resource leak.
to-be:
Use Flux.usingWhen to acquire a connection, and when done, call the (
Connection::close) method to close the connection and return.Because this method explicitly closes the connection, we've changed the resource management to allow for safe termination.