Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetryableException should hold the methodKey as well #2250

Open
nlescure-pictet opened this issue Nov 28, 2023 · 2 comments · May be fixed by #2714
Open

RetryableException should hold the methodKey as well #2250

nlescure-pictet opened this issue Nov 28, 2023 · 2 comments · May be fixed by #2714
Labels
good first issue Issues that are good for first time contributors to tackle help wanted Issues we need help with tackling proposal Proposed Specification or API change

Comments

@nlescure-pictet
Copy link

Hi there,

Referring to #719, I think it would make even more sense to add the methodKey to the RetryableException so that in the Retryer I can exactly pinpoint which method is being retried as it is done in the ErrorDecoder. That way, both implementations use the methodKey approach instead of having one relying on url/method approach and the other one on the methodKey one.

Let me know what you guys think.

Cheers
@kdavisk6 kdavisk6 added good first issue Issues that are good for first time contributors to tackle proposal Proposed Specification or API change help wanted Issues we need help with tackling labels Sep 13, 2024
@Regyl
Copy link

Regyl commented Dec 29, 2024

Hello @kdavisk6 , can I take this?

@kdavisk6
Copy link
Member

Please feel free.

@Regyl Regyl linked a pull request Jan 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are good for first time contributors to tackle help wanted Issues we need help with tackling proposal Proposed Specification or API change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add methodKey to Request & RetryableException Regyl/feign
3 participants
@kdavisk6 @Regyl @nlescure-pictet