LCD Display: Display Energy formatted to significant figures instead of decimal digits. #341
Conversation
…lue() so that it can be re-used in other methods.
… figures rather than decimals after the decima point.
…of digits after the decimal point.
rbsexton
changed the title
|
@rbsexton thanks for the contribution, been something I have been meaning to do this for a while. Will check it over. |
| "m", | ||
| "g", | ||
| "t", | ||
| "p" |
There was a problem hiding this comment.
I opened another PR before seeing this one to correct the capitalization of these units - might be worth updating it here since you're moving these around? #344
There was a problem hiding this comment.
This one has been laying around! I'd forgotten all about it. I'll update this so that it can get pulled.
There was a problem hiding this comment.
Ok. I'm pretty sure that the merge of PR#344 made mine unmergable. I'm going to start over and I'll fix the rounding error while I'm at it.
| "m", | ||
| "g", | ||
| "t", | ||
| "p" |
| // of significant figures eg, for 4: 1.00598kWh appears as 1.005 rather than 1.0 | ||
| // Overloaded on displayScaledNumberValue |
There was a problem hiding this comment.
I think this example highlights a flaw with the implementation. 1.00598kWh should be rounded up to 1.006kWh
There was a problem hiding this comment.
Good catch. printf() doesn't round. I'll add that.
The existing FW scales energy to SI notation and then places one digit after the decimal point.
This doesn't work so well for low values in kWh, ie 1.3kWh.
The ADCs in the system deliver about 3 significant figures, so display this number to a total of four - ie: