Mc 1.20 neoforge dasm wholeclass #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotStirred
force-pushed
the
MC_1.20_neoforge_dasm_wholeclass
branch
from
abda826 to
a61edab
Compare
NotStirred
force-pushed
the
MC_1.20_neoforge_dasm_wholeclass
branch
from
a61edab to
073e8a4
Compare
CursedFlames
approved these changes
Jan 14, 2024
| this.transformer.transformClass(targetClass, target, redirectSets.stream().toList()); | ||
| } else { | ||
| this.transformer.transformClass(targetClass, target, redirectSets.stream().toList()); | ||
| } |
There was a problem hiding this comment.
both branches of this if are identical?
CursedFlames
merged commit 27190d0
into
OpenCubicChunks:MC_1.20_neoforge
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #14, review after it's merged (this PR contains those commits also)
Blocked on verifying that "ugly hack to add class metadata to mixin" is safe to remove"ugly hack to add class metadata to mixin" is safe to remove, as mixin classes actually contain the DASM methods with
@TransformFrom