Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue with /doc/reference/reducers/ #236

Closed
rebinsilva opened this issue Dec 24, 2024 · 3 comments · Fixed by #237
Closed

Minor issue with /doc/reference/reducers/ #236

rebinsilva opened this issue Dec 24, 2024 · 3 comments · Fixed by #237

Comments

@rebinsilva
Copy link

Issues
In section Declaring a reducer of the reducers.md, the last code section is an example of usage of "__builtin_addressof" but uses "__builtin_address" which is non-existent.

Improvements
The "__builtin_address" can be replaced with "__builtin_addressof" in the code section

neboat added a commit that referenced this issue Jan 3, 2025
Fix typo where `__builtin_address` should be `__builtin_addressof`.  Fixes #236
@behoppe behoppe closed this as completed in 256c8b5 Jan 8, 2025
@behoppe
Copy link
Member

behoppe commented Jan 8, 2025

Thanks @rebinsilva. We fixed the typo.

If you have a moment, I'm curious to hear how you're using OpenCilk!

Thanks again for raising this issue.

@rebinsilva
Copy link
Author

@behoppe Thanks for fixing the issue soon. I am a newbie to opencilk and am using it for the Fastcode challenge at fastcode.org. I don't have much knowledge about other frameworks but am currently enjoying opencilk.

@behoppe
Copy link
Member

behoppe commented Jan 9, 2025

Hi @rebinsilva -- good luck in the competition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants