Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local reducer tables #168

Closed

Conversation

neboat
Copy link
Collaborator

@neboat neboat commented Apr 6, 2023

This PR contains changes to the OpenCilk compiler to support a new implementation of reducers in the runtime system using only local reducer tables.

neboat added 5 commits March 24, 2023 16:49
…dditional information about the reducer being looked up, namely, its view size, identity function, and reduce function.
…alysis to accommodate new hyper.lookup signature.
…allow Cilksan library to implement its own handling of reducers separately from runtime system.
@neboat neboat requested a review from VoxSciurorum April 6, 2023 02:00
@VoxSciurorum
Copy link
Contributor

Calling __hyper_lookup with bad arguments crashes the compiler. A fix is in branch jfc/local at 3437495.

@neboat
Copy link
Collaborator Author

neboat commented Apr 10, 2023

@VoxSciurorum I tried the jfc/local branch, and I'm getting a compiler crash when building Cilkscale. The crash seems to complain that the identity function for the ostream reducer has the wrong type.

@VoxSciurorum
Copy link
Contributor

I fixed the crash. See 86f1475. The cilkscale code was either not compiled on FreeBSD or was compiled with different options.

@VoxSciurorum
Copy link
Contributor

The features in this pull request have already made their way into the compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants