Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing ProductIdentification/Date time PGN handling #54

Open
martonmiklos opened this issue Dec 11, 2024 · 1 comment
Open

Implementing ProductIdentification/Date time PGN handling #54

martonmiklos opened this issue Dec 11, 2024 · 1 comment

Comments

@martonmiklos
Copy link
Contributor

I came across some implements from Kverneland which query the VT's name via the ProductIdentification (64653 PGN):
kép

I have seen in the stack that there is an "OOTB" DiagnosticProtocol implementation, we could leverage as it is (even if it might be overkill) or create a "light" class above it within the stack just serving this particular PGN, or we can just handle this PGN within the VT app.

Almost all Kverneland implements requesting date/time information:
kép

I think it would be beneficial to relay system time through this PGN too.

What do you think would it be useful to support these features?

@ad3154
Copy link
Member

ad3154 commented Dec 12, 2024

We also already have a TimeDateInterface which I actually added specifically for VT Server and File Server!

We should fully integrate the diagnostic protocol and time/date interface with the VT if it isn't currently done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants