Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting multiple softkey columns #65

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

martonmiklos
Copy link
Contributor

@martonmiklos martonmiklos commented Dec 29, 2024

I did some refactor in the AgIsoStack-plus-plus so this needs to be merged first:
Open-Agriculture/AgIsoStack-plus-plus#516

Fixes #18

@martonmiklos martonmiklos force-pushed the support_softkeymask_dimensions branch 2 times, most recently from 2a4a529 to 63bb2aa Compare January 1, 2025 19:18
Copy link
Member

@GwnDaan GwnDaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things to remain consistent with naming, other than that LGTM! Nice job

include/JuceManagedWorkingSetCache.hpp Outdated Show resolved Hide resolved
include/SoftKeyMaskComponent.hpp Outdated Show resolved Hide resolved
include/SoftKeyMaskComponent.hpp Outdated Show resolved Hide resolved
include/SoftKeyMaskComponent.hpp Outdated Show resolved Hide resolved
include/SoftKeyMaskComponent.hpp Outdated Show resolved Hide resolved
@martonmiklos martonmiklos requested a review from GwnDaan January 7, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring number of soft keys isn't reflected on-screen
2 participants