Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin a rust version in the CI/CD pipeline #36

Open
Notgnoshi opened this issue Nov 19, 2023 · 0 comments · May be fixed by #43
Open

Pin a rust version in the CI/CD pipeline #36

Notgnoshi opened this issue Nov 19, 2023 · 0 comments · May be fixed by #43
Labels
ci/cd Related to automated pipelines

Comments

@Notgnoshi
Copy link
Member

We can, and should, frequently upgrade the rust toolchain. However, there are often new lints added, which, combined with our -Dwarnings policy, cause the pipeline to fail.
@Notgnoshi Notgnoshi added the ci/cd Related to automated pipelines label Nov 19, 2023
Notgnoshi added a commit that referenced this issue Jan 27, 2024
@Notgnoshi
Pin the CI/CD Rust toolchain to latest stable
c202771 
A frequent source of CI failures (here, but mostly elsewhere) is not
pinning your compiler version. As new versions are released, new lints
and errors are added, making a project that used to build without
errors, now fail simply because there's a new release.

Now, we can, and SHOULD frequently upgrade our toolchain, but it should
still be pinned, so that we can do it on our terms.

Closes #36.
@Notgnoshi Notgnoshi linked a pull request Jan 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci/cd Related to automated pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add copyright check to CI/CD pipeline Open-Agriculture/AgIsoStack-rs
1 participant
@Notgnoshi