Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aux-N persistent assignments support #136

Open
GwnDaan opened this issue Jan 18, 2023 · 1 comment
Open

Aux-N persistent assignments support #136

GwnDaan opened this issue Jan 18, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request iso: virtual terminal Related to the ISO-11783:7 standard

Comments

@GwnDaan
Copy link
Member

GwnDaan commented Jan 18, 2023

The stack supports now basic Aux-N assignments for the VT. I think we want to have the stack save these assignments persistently and load them in on next startup. This is also what the standard requires/wants from the working set.

To make this implementation not depend on any particular storage type, my idea was to make the storage part abstract and let the application decide on the (platform specific) implementation. We can possibly also provide some of these implementations - For example the Linux and/or Windows filesystem, ESP flash storage, etc...

Related TODOs:
Auxiliary assignments should be loaded (e.g. from file/flash/cloud etc...) and then published to the VT after it loaded the object pool:
https://github.com/ad3154/ISO11783-CAN-Stack/blob/22094dd22a460e46d8778d9a40c26ac5d529a3d0/isobus/src/isobus_virtual_terminal_client.cpp#L2318
After these auxiliary assignments have been published to the VT, we expect to get an approval/denial. If the preferred assignments command is approved (and therefore the assignments are implemented) by the VT, we can have to load them in on our end as well:
https://github.com/ad3154/ISO11783-CAN-Stack/blob/22094dd22a460e46d8778d9a40c26ac5d529a3d0/isobus/src/isobus_virtual_terminal_client.cpp#L2863
If the VT operator assigns an auxiliary input to our function, and the VT wants us to save this assignment persistently, we have to store it as well. (e.g. to file/flash/cloud etc...)
https://github.com/ad3154/ISO11783-CAN-Stack/blob/22094dd22a460e46d8778d9a40c26ac5d529a3d0/isobus/src/isobus_virtual_terminal_client.cpp#L2896

Extension of #123

@GwnDaan GwnDaan added the enhancement New feature or request label Jan 18, 2023
@GwnDaan
Copy link
Member Author

GwnDaan commented Jan 21, 2023

Working on this in feature/persistent-aux-n. I implemented new layers for the storage part, but I'm not sure if I like it this way. Any feedback is welcome

@GwnDaan GwnDaan added the iso: virtual terminal Related to the ISO-11783:7 standard label Nov 10, 2023
@GwnDaan GwnDaan self-assigned this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iso: virtual terminal Related to the ISO-11783:7 standard
Projects
None yet
Development

No branches or pull requests

1 participant