Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added specific agency provider to provide agency specific links #986

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Jan 15, 2024

Fixes #

Proposed Changes

Copy link

what-the-diff bot commented Jan 15, 2024

PR Summary

  • Updates in Appointments.tsx
    The file now leverages context with AgencySpecificContext to access specificAgency and use it to generate unique keys for components and their elements.

  • Updates in FormAccordion.tsx
    This file underwent changes in its import statements and how some of the variables are handled. It now relies on AgencySpecificContext as well. The dependencies for useEffect have been updated accurately to incorporate setSpecificAgency and setIsDataProtectionSelected. Also made sure all hyperlinks and keys utilize our new context.

  • Updates in Profile.tsx
    This file got updated with features similar to Appointments.tsx. Imported AgencySpecificContext and also used it to uniquely identify key components and hyperlinks.

  • Update in RegistrationForm.tsx
    We've added an import for AgencySpecificContext, upgrading our functionality.

  • Updates in SessionMenu.tsx
    We implemented changes to enrich our hyperlink with the unique agency id from our active sessions, allowing tailored experiences.

  • Updates in StageLayout.tsx
    Another file taking advantage of the AgencySpecificContext import. The specific agency id is now used to ensure unique keys for components and improve button functionality.

  • Updates in WaitingRoom.tsx
    We implemented adjustments to hyperlink attributes, using legalLink.getUrl but due to absence of specificAgency, we've used null.

These changes adhere to better coding principles, enhance the performance of our application, and help deliver a more personalized experience to the users based on their respective agency.

janrembold
janrembold previously approved these changes Jan 16, 2024
Copy link
Contributor

@janrembold janrembold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy with another Context but ok for now

janrembold
janrembold previously approved these changes Jan 16, 2024
Copy link
Contributor

@janrembold janrembold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only 2 linting warnings left...

janrembold
janrembold previously approved these changes Jan 16, 2024
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-mi web-mi merged commit 5e6c243 into develop Jan 16, 2024
8 checks passed
@web-mi web-mi deleted the OB-5604 branch January 16, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants