Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: icon #263

Merged
merged 2 commits into from
Dec 9, 2024
Merged

feat: icon #263

merged 2 commits into from
Dec 9, 2024

Conversation

ByteZhang1024
Copy link
Contributor

@ByteZhang1024 ByteZhang1024 commented Dec 9, 2024

Summary by CodeRabbit

  • 新特性
    • 更新多个包的版本号至 2.1.22,包括 @onekeyfe/cross-inpage-provider-core@onekeyfe/cross-inpage-provider-errors@onekeyfe/cross-inpage-provider-types 等。
    • 增强钱包连接配置,支持更多钱包及其图标配置。
  • 修复
    • 改进了钱包图标查找和处理逻辑,增强了对空值的处理能力。

Copy link

coderabbitai bot commented Dec 9, 2024

Walkthrough

本次更改主要涉及多个包的版本更新。所有相关包的版本号均从 2.1.21 升级至 2.1.22,包括依赖项的版本更新。更改涉及的包包括 @onekeyfe/cross-inpage-provider-core@onekeyfe/cross-inpage-provider-errors@onekeyfe/cross-inpage-provider-types 等。部分文件还进行了代码逻辑的优化和清理。

Changes

文件路径 更改摘要
packages/core/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/core/src/versionInfo.ts 版本从 '2.1.20' 更新至 '2.1.21'
packages/desktop/desktop-bridge-injected/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/empty/package.json 版本从 2.1.21 更新至 2.1.22
packages/errors/package.json 版本从 2.1.21 更新至 2.1.22
packages/events/package.json 版本从 2.1.21 更新至 2.1.22
packages/example/package.json 版本从 2.1.21 更新至 2.1.22,多个依赖项版本更新。
packages/extension/extension-bridge-hosted/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/extension/extension-bridge-injected/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/injected/package.json 版本从 2.1.21 更新至 2.1.22,多个依赖项版本更新。
packages/native/native-bridge-injected/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/inpage-providers-hub/package.json 版本从 2.1.21 更新至 2.1.22,多个依赖项版本更新。
packages/providers/inpage-providers-hub/src/connectButtonHack/universal/config.ts 移除未使用的导入,更新钱包配置,增强代码健壮性。
packages/providers/inpage-providers-hub/src/connectButtonHack/universal/findIconAndName.ts 更新函数签名,增强日志记录。
packages/providers/inpage-providers-hub/src/connectButtonHack/universal/imgUtils.ts 修改图标节点过滤逻辑。
packages/providers/inpage-providers-hub/src/connectButtonHack/universal/index.ts 修改钱包处理逻辑,增强更新灵活性。
packages/providers/inpage-providers-hub/src/connectButtonHack/universal/type.ts 更新 FindResultType 类型定义。
packages/providers/onekey-algo-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-alph-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-aptos-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-bfc-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-btc-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-cardano-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-conflux-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-cosmos-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-eth-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-near-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-nostr-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-polkadot-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-private-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-scdo-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-solana-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-sui-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-ton-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-tron-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/providers/onekey-webln-provider/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。
packages/types/package.json 版本从 2.1.21 更新至 2.1.22
packages/webview/package.json 版本从 2.1.21 更新至 2.1.22,依赖项版本更新。

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ByteZhang1024 ByteZhang1024 enabled auto-merge (squash) December 9, 2024 08:27
Copy link

socket-security bot commented Dec 9, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Protestware or potentially unwanted behavior npm/[email protected]
  • Note: The script attempts to run a local post-install script, which could potentially contain malicious code. The error handling suggests that it is designed to fail silently, which is a common tactic in malicious scripts.
⚠︎

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 9

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between d780526 and 0c74cb8.

📒 Files selected for processing (39)
  • packages/core/package.json (2 hunks)
  • packages/core/src/loggerConsole.ts (1 hunks)
  • packages/core/src/versionInfo.ts (1 hunks)
  • packages/desktop/desktop-bridge-injected/package.json (2 hunks)
  • packages/empty/package.json (1 hunks)
  • packages/errors/package.json (1 hunks)
  • packages/events/package.json (1 hunks)
  • packages/example/package.json (2 hunks)
  • packages/extension/extension-bridge-hosted/package.json (2 hunks)
  • packages/extension/extension-bridge-injected/package.json (2 hunks)
  • packages/injected/package.json (2 hunks)
  • packages/native/native-bridge-injected/package.json (2 hunks)
  • packages/providers/inpage-providers-hub/package.json (2 hunks)
  • packages/providers/inpage-providers-hub/src/connectButtonHack/universal/config.ts (34 hunks)
  • packages/providers/inpage-providers-hub/src/connectButtonHack/universal/findIconAndName.ts (2 hunks)
  • packages/providers/inpage-providers-hub/src/connectButtonHack/universal/imgUtils.ts (1 hunks)
  • packages/providers/inpage-providers-hub/src/connectButtonHack/universal/index.ts (1 hunks)
  • packages/providers/inpage-providers-hub/src/connectButtonHack/universal/type.ts (1 hunks)
  • packages/providers/onekey-algo-provider/package.json (2 hunks)
  • packages/providers/onekey-alph-provider/package.json (2 hunks)
  • packages/providers/onekey-aptos-provider/package.json (2 hunks)
  • packages/providers/onekey-bfc-provider/package.json (2 hunks)
  • packages/providers/onekey-btc-provider/package.json (2 hunks)
  • packages/providers/onekey-cardano-provider/package.json (2 hunks)
  • packages/providers/onekey-conflux-provider/package.json (2 hunks)
  • packages/providers/onekey-cosmos-provider/package.json (2 hunks)
  • packages/providers/onekey-eth-provider/package.json (2 hunks)
  • packages/providers/onekey-near-provider/package.json (2 hunks)
  • packages/providers/onekey-nostr-provider/package.json (2 hunks)
  • packages/providers/onekey-polkadot-provider/package.json (2 hunks)
  • packages/providers/onekey-private-provider/package.json (2 hunks)
  • packages/providers/onekey-scdo-provider/package.json (2 hunks)
  • packages/providers/onekey-solana-provider/package.json (2 hunks)
  • packages/providers/onekey-sui-provider/package.json (2 hunks)
  • packages/providers/onekey-ton-provider/package.json (2 hunks)
  • packages/providers/onekey-tron-provider/package.json (2 hunks)
  • packages/providers/onekey-webln-provider/package.json (2 hunks)
  • packages/types/package.json (1 hunks)
  • packages/webview/package.json (2 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
packages/providers/inpage-providers-hub/src/connectButtonHack/universal/config.ts

[error] 360-360: The assignment should not be in an expression.

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

(lint/suspicious/noAssignInExpressions)


[error] 367-367: The assignment should not be in an expression.

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

(lint/suspicious/noAssignInExpressions)

🔇 Additional comments (38)
packages/providers/inpage-providers-hub/src/connectButtonHack/universal/config.ts (2)

146-146: 更改已批准

afterUpdate 方法的参数现在支持 null 值,增强了代码的健壮性。


213-219: 添加 Petra 钱包的配置

成功添加了 Petra 钱包在 RainbowKit 中的配置,代码清晰且易于维护。

packages/providers/inpage-providers-hub/src/connectButtonHack/universal/type.ts (1)

3-3: 更新了 iconNode 的类型

iconNode 的类型更新为 HTMLElement | null,提高了代码的健壮性,便于处理缺少图标的情况。

packages/events/package.json (1)

3-3: 版本号已正确更新

package.json 中的版本号已更新为 '2.1.22',与其他相关包保持一致。

packages/types/package.json (1)

3-3: 版本更新正确!

版本号从 2.1.21 更新到 2.1.22,与其他包保持一致。

packages/empty/package.json (1)

3-3: 版本更新正确!

版本号从 2.1.21 更新到 2.1.22,与其他包保持一致。

packages/errors/package.json (1)

3-3: 版本更新正确!

版本号从 2.1.21 更新到 2.1.22,与其他包保持一致。

✅ Verification successful

版本号检查通过!

所有包的版本号都已统一更新至 2.1.22,完全一致,没有发现任何版本不匹配的情况。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有包的版本是否一致

# 查找所有 package.json 文件并检查版本号
echo "检查所有包的版本号..."
find . -name "package.json" -not -path "*/node_modules/*" -exec grep -H "\"version\":" {} \;

Length of output: 2554

packages/native/native-bridge-injected/package.json (1)

3-3: 版本更新看起来符合规范

包版本和依赖版本都统一更新到了 2.1.22,保持了版本一致性。

Also applies to: 31-32

packages/extension/extension-bridge-injected/package.json (1)

3-3: 版本更新保持一致性

与其他包保持同步更新到 2.1.22 版本,依赖关系更新合理。

Also applies to: 31-32

packages/extension/extension-bridge-hosted/package.json (1)

3-3: 版本号更新正确,但需要确认功能相关性

版本更新到 2.1.22 符合规范,但是:

  1. PR 标题提到了 icon 功能,但在这些更改中没有看到相关代码
  2. 建议确认是否有遗漏的改动文件

Also applies to: 31-32

packages/desktop/desktop-bridge-injected/package.json (1)

3-3: 版本更新看起来没问题!

包版本和依赖版本都已同步更新至 2.1.22,保持了版本一致性。

Also applies to: 37-38

packages/providers/onekey-btc-provider/package.json (1)

3-3: 版本更新正确!

包版本和所有依赖版本都已更新至 2.1.22,维持了良好的版本一致性。

Also applies to: 31-34

packages/providers/onekey-scdo-provider/package.json (1)

3-3: 版本更新完成,建议验证所有包!

包版本和依赖版本都已更新至 2.1.22。为确保发布顺利,建议验证所有相关包的版本是否都已同步更新。

Also applies to: 31-34

✅ Verification successful

版本更新已完全同步!

经验证,所有包的版本号和依赖版本都已成功更新至 2.1.22,包括:

  • 所有 package.json 中的 version 字段均为 2.1.22
  • 所有 @onekeyfe 相关依赖的版本号均为 2.1.22
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有 package.json 文件中的版本号
echo "检查所有包的版本号..."
find . -name "package.json" -not -path "*/node_modules/*" -exec grep -H "\"version\":" {} \;

echo "\n检查所有 @onekeyfe 依赖的版本号..."
find . -name "package.json" -not -path "*/node_modules/*" -exec grep -H "\"@onekeyfe/" {} \;

Length of output: 18978

packages/providers/onekey-algo-provider/package.json (1)

3-3: 版本更新看起来没问题!

版本号和依赖项的更新保持一致,符合预期。

Also applies to: 31-34

packages/providers/onekey-webln-provider/package.json (1)

3-3: 版本更新正确!

版本号和依赖关系的更新与其他包保持同步。

Also applies to: 31-34

packages/providers/onekey-nostr-provider/package.json (1)

3-3: 版本更新完成!建议验证所有包的版本一致性

版本号和依赖项更新符合预期。为确保整个项目的版本一致性,建议进行全面检查。

Also applies to: 31-34

✅ Verification successful

版本号已完全一致,验证通过!

从检查结果可以看到,所有包的版本号都已统一更新到 2.1.22,包括:

  • 所有 package.json 中声明的版本号
  • 所有依赖项中 @onekeyfe 相关包的引用版本
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有包的版本号是否一致
echo "检查所有 package.json 文件中的版本号..."
fd -e json -x jq -r '. | select(.version != null) | .name + ": " + .version' {}

echo -e "\n检查所有依赖项中 @onekeyfe 相关包的版本..."
fd -e json -x jq -r '.dependencies | with_entries(select(.key | startswith("@onekeyfe"))) | to_entries[] | .key + ": " + .value' {}

Length of output: 13895

packages/providers/onekey-conflux-provider/package.json (1)

3-3: 版本更新符合预期

版本号和依赖项更新与其他包保持同步,确保了整体一致性。

Also applies to: 31-34

packages/webview/package.json (1)

3-3: 版本更新完整且同步

webview 包的版本号和核心依赖更新已完成,与其他包保持一致。建议在更新后进行完整的集成测试。

Also applies to: 39-40

packages/providers/onekey-cardano-provider/package.json (1)

3-3: 版本更新看起来没有问题!

包版本和依赖版本都统一更新到了 2.1.22,保持了良好的一致性。

Also applies to: 32-35

packages/providers/onekey-ton-provider/package.json (1)

3-3: 版本更新符合预期!

包版本和内部依赖都更新到了 2.1.22,同时保持了外部依赖 @tonconnect/protocol 的版本不变,这是正确的做法。

Also applies to: 31-34

packages/providers/onekey-sui-provider/package.json (1)

3-3: 版本更新正确,建议验证整体一致性!

包版本和内部依赖都已更新到 2.1.22,外部依赖版本保持不变。建议验证所有相关包的版本是否都已同步更新。

Also applies to: 32-35

✅ Verification successful

版本更新已完全同步,无需进一步验证!

检查结果显示所有包的版本号和内部依赖都已统一更新到 2.1.22,包括:

  • 所有 provider 包
  • 所有核心包(core、types、errors 等)
  • 所有桥接包(bridge-injected)
  • 所有内部依赖(@onekeyfe/*)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有包的版本是否统一更新到 2.1.22

# 查找所有 package.json 文件
echo "检查所有包的版本号..."
fd package.json packages/ -x grep -H '"version":'

# 检查所有 @onekeyfe 依赖的版本
echo -e "\n检查所有 @onekeyfe 依赖的版本..."
fd package.json packages/ -x grep -H '"@onekeyfe/'

Length of output: 18514

packages/providers/onekey-eth-provider/package.json (1)

3-3: 版本更新看起来很合理!

版本号从 2.1.21 升级到 2.1.22,相关依赖包也同步更新,保持了版本一致性。

让我们验证一下所有包的版本是否一致:

Also applies to: 31-34

✅ Verification successful

版本号已完全同步,一切正常!

从检查结果来看,所有包的版本号都已统一更新到 2.1.22,包括:

  • @onekeyfe/onekey-eth-provider
  • 其他所有 provider 包
  • 所有核心基础包
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有包的版本号是否一致
echo "检查 package.json 文件中的版本号..."
fd -e json -x jq -r '. | select(.version != null) | "\(.name): \(.version)"'

Length of output: 1620

packages/providers/onekey-cosmos-provider/package.json (1)

3-3: 版本更新保持一致!

版本号和依赖包都已更新到 2.1.22,与其他包保持同步。

Also applies to: 32-35

packages/providers/onekey-tron-provider/package.json (1)

3-3: 版本更新完成!

版本号和依赖包都已更新到 2.1.22,确保了整个项目的版本一致性。

Also applies to: 32-35

packages/providers/onekey-bfc-provider/package.json (1)

3-3: 版本更新完整,需检查 bfc.js 兼容性

版本更新符合预期:

  • 包版本已更新至 2.1.22
  • 所有 @onekeyfe 依赖已同步至 2.1.22

Also applies to: 32-35

✅ Verification successful

版本检查完成,所有依赖版本均正确

@benfen/bfc.js 当前使用的 0.2.7 版本是最新版本,无需更新。所有包版本均保持一致且为最新。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查 @benfen/bfc.js 的最新版本,确认 0.2.7 是否需要更新
curl -s https://registry.npmjs.org/@benfen/bfc.js/latest | jq '.version'

Length of output: 80

packages/core/package.json (1)

3-3: 版本更新看起来没有问题!

所有相关依赖包版本都已同步更新到 2.1.22,保持了版本一致性。

运行以下脚本验证所有相关包的版本一致性:

Also applies to: 32-34

✅ Verification successful

版本一致性验证通过!

所有 @onekeyfe 相关包均已更新至 2.1.22 版本,完全保持同步。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有 package.json 中的版本号是否一致
fd -e json -x jq -r '. | select(.name | startswith("@onekeyfe")) | .version, (.dependencies | select(. != null) | with_entries(select(.key | startswith("@onekeyfe"))) | .[])' {} \;

Length of output: 8138


Script:

#!/bin/bash
# 使用更精确的命令来检查 package.json 文件中的版本
fd package.json -x jq -r 'select(.name != null and (.name | startswith("@onekeyfe"))) | "\(.name): \(.version)"' {}

Length of output: 1450

packages/providers/onekey-near-provider/package.json (1)

3-3: 版本更新正确!

包版本和所有 @onekeyfe 依赖都已更新到 2.1.22,与核心包保持一致。

Also applies to: 38-41

packages/providers/onekey-solana-provider/package.json (1)

3-3: 版本更新完成!

包版本和所有 @onekeyfe 依赖都已更新到 2.1.22,与其他包保持同步。

Also applies to: 32-35

packages/providers/onekey-aptos-provider/package.json (1)

3-3: 版本更新看起来很合理!

所有依赖包版本都同步更新到了 2.1.22,保持了版本一致性。

Also applies to: 32-35

packages/injected/package.json (1)

3-3: 依赖版本更新正确!

所有相关依赖包都已更新到 2.1.22 版本,维持了整个项目的版本一致性。

Also applies to: 45-50

packages/providers/inpage-providers-hub/package.json (1)

3-3: 版本更新看起来很合理!

所有 @onekeyfe 相关的依赖包版本都同步更新到了 2.1.22,保持了版本一致性。

Also applies to: 33-52

packages/providers/inpage-providers-hub/src/connectButtonHack/universal/index.ts (2)

77-85: 空值处理改进很棒!

代码更健壮了:

  • 分别处理 textNode 和 iconNode
  • 避免了不必要的空值检查
  • 更新逻辑更清晰

86-89: 🧹 Nitpick (assertive)

建议改进错误处理的可读性

当前的错误日志可能不够详细,建议添加更多上下文信息。

- universalLog.warn(e);
+ universalLog.warn(`更新钱包 ${wallet.name} 时发生错误:`, e);

Likely invalid or redundant comment.

packages/providers/inpage-providers-hub/src/connectButtonHack/universal/findIconAndName.ts (4)

15-18: 类型定义更新增强了图标控制

通过添加 'none' 选项,使图标控制更加灵活和明确。这是一个很好的改进。


26-26: 日志级别调整更合理

将日志从 log 改为 debug 更符合这些消息的性质,这是一个好的实践。

Also applies to: 30-30


54-57: 图标检查逻辑更完善

新增的条件检查很好地处理了 'none' 选项的情况,提高了代码的健壮性。


59-59: 返回值处理更明确

使用空值合并运算符使返回值的处理更加清晰。

packages/example/package.json (1)

3-3: 依赖版本更新需要验证兼容性

所有 OneKey 相关依赖包都更新到了 2.1.22 版本,建议:

  1. 确保所有依赖包的版本更新是同步的
  2. 验证是否有破坏性更新

Also applies to: 28-38

✅ Verification successful

Let me generate another verification script to check the version consistency more precisely.


版本更新已完全同步

检查结果显示所有 @onekeyfe 相关的包都已统一更新到 2.1.22 版本,包括:

  • 核心包
  • 桥接包
  • 各链的 provider 包
  • 类型定义包

无需额外验证。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有相关包的版本一致性
echo "检查版本一致性..."
for pkg in $(find . -name "package.json"); do
  if grep -q "@onekeyfe/" "$pkg"; then
    echo "检查 $pkg"
    grep "@onekeyfe/" "$pkg" | grep -v "2.1.22"
  fi
done

Length of output: 44315


Script:

#!/bin/bash
# 检查所有package.json中的版本号和依赖版本
echo "检查版本号和依赖版本..."
for pkg in $(find . -name "package.json"); do
  if grep -q "\"version\":" "$pkg"; then
    echo "=== $pkg ==="
    grep "\"version\":" "$pkg"
    grep -A 20 "\"dependencies\":" "$pkg" | grep "@onekeyfe/"
    grep -A 20 "\"devDependencies\":" "$pkg" | grep "@onekeyfe/"
    echo
  fi
done

Length of output: 98963

Copy link

Report too large to display inline

View full report↗︎

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 0c74cb8 and f97ae4d.

📒 Files selected for processing (32)
  • packages/core/package.json (2 hunks)
  • packages/desktop/desktop-bridge-injected/package.json (2 hunks)
  • packages/empty/package.json (1 hunks)
  • packages/errors/package.json (1 hunks)
  • packages/events/package.json (1 hunks)
  • packages/example/package.json (2 hunks)
  • packages/extension/extension-bridge-hosted/package.json (2 hunks)
  • packages/extension/extension-bridge-injected/package.json (2 hunks)
  • packages/injected/package.json (2 hunks)
  • packages/native/native-bridge-injected/package.json (2 hunks)
  • packages/providers/inpage-providers-hub/package.json (2 hunks)
  • packages/providers/onekey-algo-provider/package.json (2 hunks)
  • packages/providers/onekey-alph-provider/package.json (2 hunks)
  • packages/providers/onekey-aptos-provider/package.json (2 hunks)
  • packages/providers/onekey-bfc-provider/package.json (2 hunks)
  • packages/providers/onekey-btc-provider/package.json (2 hunks)
  • packages/providers/onekey-cardano-provider/package.json (2 hunks)
  • packages/providers/onekey-conflux-provider/package.json (2 hunks)
  • packages/providers/onekey-cosmos-provider/package.json (2 hunks)
  • packages/providers/onekey-eth-provider/package.json (2 hunks)
  • packages/providers/onekey-near-provider/package.json (2 hunks)
  • packages/providers/onekey-nostr-provider/package.json (2 hunks)
  • packages/providers/onekey-polkadot-provider/package.json (2 hunks)
  • packages/providers/onekey-private-provider/package.json (2 hunks)
  • packages/providers/onekey-scdo-provider/package.json (2 hunks)
  • packages/providers/onekey-solana-provider/package.json (2 hunks)
  • packages/providers/onekey-sui-provider/package.json (2 hunks)
  • packages/providers/onekey-ton-provider/package.json (2 hunks)
  • packages/providers/onekey-tron-provider/package.json (2 hunks)
  • packages/providers/onekey-webln-provider/package.json (2 hunks)
  • packages/types/package.json (1 hunks)
  • packages/webview/package.json (2 hunks)
🔇 Additional comments (33)
packages/providers/onekey-eth-provider/package.json (2)

3-3: 版本号更新已确认

包版本从 2.1.21 升级到 2.1.22,符合语义化版本规范。


31-34: 🧹 Nitpick (assertive)

依赖包版本更新验证

所有相关依赖包版本已统一更新至 2.1.22,保持了版本一致性。建议验证这些依赖包的更新是否包含重大变更。

packages/events/package.json (1)

3-3: 版本更新验证

版本号已更新至 2.1.22,需要确保与其他相关包保持一致。

✅ Verification successful

版本号已完全同步

所有 @onekeyfe 相关包的版本号均已更新至 2.1.22,版本保持一致。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有包的版本是否一致
find . -name "package.json" -exec jq -r '. | select(.name | startswith("@onekeyfe/")) | .name + ": " + .version' {} \;

Length of output: 1452

packages/types/package.json (1)

3-3: 配置正确

版本更新和TypeScript配置都符合规范。

packages/errors/package.json (1)

3-3: 版本更新已确认!

版本号从 2.1.21 更新到 2.1.22,符合语义化版本规范。

packages/native/native-bridge-injected/package.json (1)

3-3: 依赖版本同步更新已确认!

包版本和依赖版本都已更新到 2.1.22,保持了版本一致性。建议验证其他相关包的版本同步情况。

Also applies to: 31-32

✅ Verification successful

版本同步已完全确认!

所有 @onekeyfe 相关包均已更新至 2.1.22 版本,保持了完整的版本一致性。无需进一步验证。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有相关包的版本一致性
fd -e json -x jq -r '. | select(.name | startswith("@onekeyfe")) | .name + ": " + .version' {} \;

Length of output: 8280

packages/extension/extension-bridge-injected/package.json (1)

3-3: 版本更新保持一致性!

版本号和依赖更新符合预期:

  • 包版本更新至 2.1.22
  • 核心依赖同步更新至 2.1.22

这些更改与其他包保持同步,维护了整体一致性。

Also applies to: 31-32

packages/extension/extension-bridge-hosted/package.json (1)

3-3: 版本更新看起来没有问题!

版本号和依赖项的更新保持一致,符合项目规范。

Also applies to: 31-32

packages/desktop/desktop-bridge-injected/package.json (1)

3-3: 版本同步更新正确!

包版本和依赖版本都已更新到 2.1.22,保持同步。

Also applies to: 37-38

packages/providers/onekey-btc-provider/package.json (1)

3-3: 建议验证所有相关包的版本更新

虽然当前包的版本更新正确,但建议确认所有相关包都已更新到相同版本。

运行以下脚本验证所有包的版本一致性:

Also applies to: 31-34

✅ Verification successful

所有相关包已成功更新到 2.1.22 版本

通过检查发现,所有包的版本都已统一更新到 2.1.22,版本同步完整且一致。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有包的版本是否统一更新到 2.1.22

echo "检查 package.json 文件中的版本..."
fd -e json -x jq -r '. | select(.version != null) | .name + ": " + .version' {}

Length of output: 1619

packages/providers/onekey-scdo-provider/package.json (1)

3-3: 版本更新检查

包版本和依赖版本都已更新至 2.1.22,保持一致性。建议验证整个项目中的版本一致性。

Also applies to: 31-34

✅ Verification successful

版本一致性验证已完成

经检查,所有 @onekeyfe 相关的包和依赖版本均已统一更新至 2.1.22,版本保持一致。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有包的版本一致性
echo "检查 package.json 文件中的版本..."
find . -name "package.json" -type f -exec jq -r '. | select(.name | startswith("@onekeyfe")) | .name + ": " + .version' {} \;

echo "检查依赖版本..."
find . -name "package.json" -type f -exec jq -r '. | select(.dependencies != null) | .dependencies | to_entries[] | select(.key | startswith("@onekeyfe")) | .key + ": " + .value' {} \;

Length of output: 7375

packages/providers/onekey-algo-provider/package.json (1)

3-3: 版本更新验证

版本号和依赖项更新符合预期。

Also applies to: 31-34

packages/providers/onekey-nostr-provider/package.json (1)

3-3: 版本升级确认

版本更新保持一致性,无其他问题。

Also applies to: 31-34

packages/providers/onekey-webln-provider/package.json (1)

3-3: 需要确保版本更新的一致性

版本号从 2.1.21 升级到 2.1.22,依赖项版本也相应更新。但根据之前的检查,以下文件仍需更新:

  • packages/core/src/versionInfo.ts
  • packages/example/server/wrappers/walletContractV4R1.ts
#!/bin/bash
# 检查版本一致性

# 检查所有 package.json 中的版本号
fd -e json -x grep -l "version" {} | xargs cat | grep "version"

# 检查是否还有遗漏的旧版本引用
rg "2.1.21" -l

Also applies to: 31-34

packages/providers/onekey-conflux-provider/package.json (1)

3-3: 版本更新正确

版本号和依赖项更新符合预期。

Also applies to: 31-34

packages/webview/package.json (1)

3-3: 版本更新需要补充说明

包版本和依赖版本都已更新至 2.1.22,更新保持一致性。但是 PR 标题提到 "icon" 与实际的版本更新改动不符,建议:

  1. 补充 PR 描述,说明版本更新的原因
  2. 修改 PR 标题以反映实际改动

Also applies to: 39-40

✅ Verification successful

版本更新已验证一致

所有包的版本都已统一更新至 2.1.22,保持了良好的版本一致性。建议:

  1. 在 PR 描述中补充版本更新的原因
  2. 修改 PR 标题以反映版本更新的改动,而不是仅提及 "icon"
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有 package.json 文件中的版本一致性
fd -e json -x cat {} \; | jq 'select(.version != null) | {name: .name, version: .version}'

Length of output: 1657

packages/providers/onekey-cardano-provider/package.json (1)

3-3: 依赖版本更新完整且一致

包版本和所有相关依赖都已更新至 2.1.22,保持了版本一致性。

Also applies to: 32-35

packages/providers/onekey-ton-provider/package.json (1)

3-3: 依赖版本更新完整且一致

包版本和所有 @onekeyfe 相关依赖都已更新至 2.1.22,保持了版本一致性。外部依赖 @tonconnect/protocol 版本保持不变,符合预期。

Also applies to: 31-34

packages/providers/onekey-sui-provider/package.json (1)

3-3: 版本更新检查通过

包版本和依赖版本统一更新至 2.1.22,保持了版本一致性。

执行以下脚本验证所有相关包的版本一致性:

Also applies to: 32-35

✅ Verification successful

版本一致性确认完成

所有 @onekeyfe 相关包均已统一更新至 2.1.22 版本,保持了完整的版本一致性。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有包的版本号是否一致
fd -e json -x jq -r '. | select(.name | startswith("@onekeyfe")) | .version' {} \;

Length of output: 7158


Script:

#!/bin/bash
# 使用更精确的命令检查包版本
fd package.json -t f -x sh -c 'if grep -q "\"@onekeyfe/" {}; then echo "=== {} ==="; cat {} | jq -r ".version"' \;

Length of output: 2130


Script:

#!/bin/bash
# 修复语法并检查包版本
fd package.json -t f -x sh -c 'if grep -q "\"@onekeyfe/" {}; then echo "=== {} ==="; cat {} | jq -r ".version"; fi' \;

Length of output: 2192

packages/providers/onekey-cosmos-provider/package.json (1)

3-3: 版本更新保持一致

包版本和依赖版本更新符合预期,与其他包保持同步。

Also applies to: 32-35

packages/providers/onekey-tron-provider/package.json (2)

3-3: 版本更新已确认

包版本和依赖版本更新符合预期,与其他包保持一致。

Also applies to: 32-35


Line range hint 1-39: 请确认PR标题与更改内容的一致性

PR标题为"feat: icon",但当前更改仅包含版本号更新,没有发现图标相关的改动。建议更新PR标题以准确反映当前更改内容。

执行以下脚本搜索是否存在未提供的图标相关更改:

packages/providers/onekey-alph-provider/package.json (2)

34-37: 依赖版本更新已完成

@onekeyfe 相关依赖已统一更新至 2.1.22 版本。


34-34: @alephium 依赖需要更新至最新版本

当前使用的 @alephium 依赖版本 (1.5.2) 已过时,建议更新以下依赖:

  • @alephium/web3
  • @alephium/get-extension-wallet
  • @alephium/walletconnect-provider

Also applies to: 35-35, 36-36, 37-37

packages/providers/onekey-bfc-provider/package.json (1)

32-35: 依赖版本更新检查

@onekeyfe 相关依赖已统一更新至 2.1.22 版本。建议验证 @benfen/bfc.js 0.2.7 版本的兼容性。

✅ Verification successful

依赖版本检查已完成

@benfen/bfc.js 当前使用的 0.2.7 版本与 npm registry 中的最新版本一致,无需更新。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查 @benfen/bfc.js 的最新版本
curl -s https://registry.npmjs.org/@benfen/bfc.js/latest | jq '.version'

Length of output: 80

packages/providers/onekey-polkadot-provider/package.json (2)

32-35: 依赖版本更新已完成

@onekeyfe 相关依赖已统一更新至 2.1.22 版本。


36-36: 建议更新 @polkadot/extension-inject 依赖版本

当前使用的版本 ^0.46.3 已过时,最新版本为 0.57.1,建议评估升级的可能性。

packages/core/package.json (1)

3-3: 版本更新检查通过!

包版本和依赖版本都已同步更新至 2.1.22,保持了良好的一致性。

Also applies to: 32-34

packages/providers/onekey-solana-provider/package.json (1)

3-3: 依赖版本同步更新完成!

主版本号和所有相关依赖包均已更新至 2.1.22,确保了包之间的兼容性。

Also applies to: 32-35

packages/providers/onekey-near-provider/package.json (1)

3-3: 版本同步更新已完成!

包版本和依赖版本已统一更新至 2.1.22。

运行以下脚本验证所有包的版本一致性:

Also applies to: 38-41

✅ Verification successful

版本同步验证通过!

所有包和依赖已成功更新至 2.1.22 版本,包括:

  • 所有 @onekeyfe 包的版本号统一为 2.1.22
  • 所有 @onekeyfe 相关依赖的版本号统一为 2.1.22
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 描述:验证所有包的版本号是否统一更新至 2.1.22

# 检查所有 package.json 文件中的版本号
echo "检查包版本..."
fd -e json -x jq -r '. | select(.version != null) | .name + ": " + .version' {}

# 检查所有 @onekeyfe 相关依赖的版本号
echo -e "\n检查依赖版本..."
fd -e json -x jq -r '.dependencies | select(. != null) | to_entries[] | select(.key | startswith("@onekeyfe")) | .key + ": " + .value' {}

Length of output: 7519

packages/injected/package.json (1)

3-3: 依赖版本更新完整且一致

所有相关依赖包版本均已同步更新至 2.1.22,保持了版本一致性。

Also applies to: 45-50

packages/example/package.json (2)

3-3: 包版本更新至 2.1.22

版本号更新符合语义化版本规范。


28-38: OneKey 相关依赖包版本同步更新

所有 OneKey 相关依赖包版本已统一更新至 2.1.22,保持了版本一致性。建议验证这些依赖包之间是否存在兼容性问题。

✅ Verification successful

所有 OneKey 相关依赖包版本已完全同步

经过验证,所有 package.json 文件中的 @onekeyfe 相关依赖包版本均已统一为 2.1.22,包括:

  • 核心包(cross-inpage-provider-core/types/errors/events)
  • 各链的 provider 包(eth/btc/cosmos 等)
  • 桥接包(desktop/extension/native-bridge)

版本完全一致,无需担心兼容性问题。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查所有 OneKey 依赖包的版本一致性
echo "检查 OneKey 依赖包版本..."
for pkg in $(find . -name "package.json"); do
  echo "检查文件: $pkg"
  cat $pkg | jq -r '.dependencies | with_entries(select(.key | startswith("@onekeyfe"))) | to_entries[] | "\(.key): \(.value)"'
done

Length of output: 16821

@ByteZhang1024 ByteZhang1024 merged commit b3d85c2 into master Dec 9, 2024
6 of 7 checks passed
@ByteZhang1024 ByteZhang1024 deleted the feat/icon branch December 9, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants