Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Scrollbars When Viewing Trip Details in StopPane Modal #128

Closed
Ahmedhossamdev opened this issue Nov 22, 2024 · 2 comments · Fixed by #137
Closed

Duplicate Scrollbars When Viewing Trip Details in StopPane Modal #128

Ahmedhossamdev opened this issue Nov 22, 2024 · 2 comments · Fixed by #137
Assignees
Labels
bug Something isn't working

Comments

@Ahmedhossamdev
Copy link
Member

Ahmedhossamdev commented Nov 22, 2024

Description

When opening the stopPane modal and then the tripDetails modal:

  • Two scrollbars appear in the tripDetailsModal and arrivalsAndDepartures sections.

  • The arrivalsAndDepartures section in the stopPane modal remains open. It should be closed automatically when the tripDetails modal is opened.

  • Additionally, we need to handle the case when the stopPane is used outside the modalPane. In this case:

    • The inner scroll should be activated for the stopPane.
    • When the stopPane is used within the modalPane, the scroll should be disabled to prevent redundant scrollbars.

Steps to Fix

  • Remove the overflow-y-auto and scroll from the arrivalsAndDepartures and tripDetailsModal, as the modalPane already contains overflow-y-auto.

  • Implement logic to conditionally enable or disable the inner scroll for the stopPane:

    • Enable inner scroll when stopPane is used outside modalPane.
    • Disable inner scroll when stopPane is used within modalPane.

image

@Ahmedhossamdev Ahmedhossamdev added the bug Something isn't working label Nov 22, 2024
@Ahmedhossamdev Ahmedhossamdev self-assigned this Nov 22, 2024
@aaronbrethorst
Copy link
Member

I think this is best fixed with the draft PR I have opened: #129 - can you finish that up with the new accordion style UI for the trip details pane?

@Ahmedhossamdev
Copy link
Member Author

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants