We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When opening the stopPane modal and then the tripDetails modal:
stopPane
tripDetails
Two scrollbars appear in the tripDetailsModal and arrivalsAndDepartures sections.
tripDetailsModal
arrivalsAndDepartures
The arrivalsAndDepartures section in the stopPane modal remains open. It should be closed automatically when the tripDetails modal is opened.
Additionally, we need to handle the case when the stopPane is used outside the modalPane. In this case:
modalPane
Remove the overflow-y-auto and scroll from the arrivalsAndDepartures and tripDetailsModal, as the modalPane already contains overflow-y-auto.
overflow-y-auto
scroll
Implement logic to conditionally enable or disable the inner scroll for the stopPane:
The text was updated successfully, but these errors were encountered:
I think this is best fixed with the draft PR I have opened: #129 - can you finish that up with the new accordion style UI for the trip details pane?
Sorry, something went wrong.
Great
Ahmedhossamdev
Successfully merging a pull request may close this issue.
Description
When opening the
stopPane
modal and then thetripDetails
modal:Two scrollbars appear in the
tripDetailsModal
andarrivalsAndDepartures
sections.The
arrivalsAndDepartures
section in thestopPane
modal remains open. It should be closed automatically when thetripDetails
modal is opened.Additionally, we need to handle the case when the
stopPane
is used outside themodalPane
. In this case:stopPane
.stopPane
is used within themodalPane
, the scroll should be disabled to prevent redundant scrollbars.Steps to Fix
Remove the
overflow-y-auto
andscroll
from thearrivalsAndDepartures
andtripDetailsModal
, as themodalPane
already containsoverflow-y-auto
.Implement logic to conditionally enable or disable the inner scroll for the
stopPane
:stopPane
is used outsidemodalPane
.stopPane
is used withinmodalPane
.The text was updated successfully, but these errors were encountered: