Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run K Commands: gnome-terminal not found #21

Open
ThatRendle opened this issue Jan 27, 2015 · 3 comments
Open

Run K Commands: gnome-terminal not found #21

ThatRendle opened this issue Jan 27, 2015 · 3 comments

Comments

@ThatRendle
Copy link

I'm running Sublime on ElementaryOS 0.3 Beta 1, and when I tried to run k mon from Run K Commands I got a message box saying "Terminal: The terminal gnome-terminal was not found".

I've installed it from apt-get and everything is fine, but it seems like an odd dependency.

@sayedihashimi
Copy link
Member

I have an outstanding pr which I need to merge at #20. Will that solve your problem?

@nosami
Copy link

nosami commented Jan 27, 2015

This looks like a different problem. The code assumes that if you are running a gnome session, then you have gnome-terminal installed

if wm[0] == 'gnome-session':

It's probably a reasonable assumption, but ElementaryOS is quite obscure!

I think the code should probably check if the terminal actually exists. xterm is pretty much ubiquitous on linux, but as it's pretty basic, it should be used only as a fallback.

I use urxvt for what it's worth :)

@sayedihashimi
Copy link
Member

Thanks @nosami I have marked it as help-wanted if we get a PR I may ask you to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants