Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the core groupHomePath feature #5

Closed
stigfaerch opened this issue Jan 3, 2022 · 5 comments · May be fixed by #6
Closed

Add support for the core groupHomePath feature #5

stigfaerch opened this issue Jan 3, 2022 · 5 comments · May be fixed by #6

Comments

@stigfaerch
Copy link
Contributor

As described here:
https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ApiOverview/AccessControl/MoreAboutFileMounts/Index.html#home-directories

The core feature makes it possible for backend user groups to have access to a folder the user group uid as name inside the groupHomePath, without having to create any file mounts.

@Oktopuce
Copy link
Owner

Oktopuce commented Jan 3, 2022

Thanks for proposing this new feature but my approach would be different.

To achieve this I would better implement something like this :

  • in getDataSecondStepAction(), check If $GLOBALS['TYPO3_CONF_VARS']['BE']['groupHomePath'] is defined and well configured and if so, add a variable to the view groupHomePath = true
  • in the GetDataSecondStep.html view if groupHomePath = true then add a checkbox with the property property="groupHomePath" and of course the setter and getter in SiteGeneratorDto
  • if this checkbox is checked then the form field 'Base folder name' must be disabled with some JS
  • then in Classes/Wizard/StateCreateFolder.php, you can set the right storageUid and baseFolderName according to the flag in DTO
  • could be interesting to have a checkbox in extension configuration telling to the view if the groupHomePath should be checked by default or not

@stigfaerch
Copy link
Contributor Author

@Oktopuce I'll try to implement that.

@stigfaerch
Copy link
Contributor Author

@Oktopuce Just pushed some changes. Have a look at it. I didn't implement your last suggestion yet though.

@stigfaerch
Copy link
Contributor Author

As I needed this feature and could not wait, I decided to include it in our extension extending Site Generator.
Of course there will be no option to choose between the to methods, but I don't think of it as an issue. At least not for us.
So it is up to you if we should abandon this feature from Site Generator.

@Oktopuce
Copy link
Owner

Sorry but there were some development in your PR that I would like to be different but haven't got the time to review them.
And yes this is not an issue but a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants