Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifeste validation do not alert what Outlook for web add-in installation will throw #591

Closed
3 tasks done
dimitri-bourreau opened this issue Dec 3, 2020 · 3 comments
Closed
3 tasks done
Assignees

Comments

@dimitri-bourreau
Copy link

  • I am running the latest version of Node and the tools
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Expected behavior

npm run validate would alert if the manifest could not be installed on Outlook for web.

Current behavior

npm run validate do not throw the error specified by Outlook for web when refusing the installation of the manifeste.

npm run validate throws two errors about images, an issue is already open about this.

Outlook refuses the installation throwing:

La section VersionOverrides 1.0 du manifeste n’est pas valide. La balise resid n’est pas valide.

Which would translate:

The VersionOverrides 1.0 section of the manifest is invalid. The resid is not valid.

And this error didn't help me has actually I only needed to add this to my manifest:

          <Runtimes>
            <Runtime resid="WebViewRuntime.Url">
              <Override type="javascript" resid="JSRuntime.Url"/>
            </Runtime>
          </Runtimes>

This snippet wasn't included by Yeoman at generation.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. yo office and generate an Outlook add-in with SSO and JavaScript.
  2. Add event-based action such as:
            <ExtensionPoint xsi:type="LaunchEvent">
              <LaunchEvents>
                <LaunchEvent 
                  Type="OnNewMessageCompose" 
                  FunctionName="reactToNewMessage"
                />
              </LaunchEvents>
              <SourceLocation resid="WebViewRuntime.Url"/>
            </ExtensionPoint>

I'm not sure this is enough. Though, I checked twice the Current behavior section.

Context

  • Operating System: Windows 10
  • Node version: 14.15.1
@igor-ribeiiro
Copy link
Contributor

Hey @dimitri-bourreau what kind of setup are you using currently on yo-office?
I just created a fresh project using the following:

? Choose a project type: Office Add-in Task Pane project supporting single sign-on
? Choose a script type: JavaScript
? What do you want to name your add-in? sso2
? Which Office client application would you like to support? Outlook

And I'm not getting this VersionOverride error.
I'm getting a lot of errors normally in the npm run validate step, which most seem related to the images in the manifest. Did you work around them? I feel the template might be outdated and not working right now because of these errors.

@igor-ribeiiro
Copy link
Contributor

I Will be closing this issue as I didn't get any response

@dimitri-bourreau
Copy link
Author

dimitri-bourreau commented Nov 10, 2021

@igor-ribeiiro I'm so sorry I've totally forgot about this issue and I haven't seen your answer probably by checking notifications too fast!

If I find this error again I'll share my setup and a demo repo.
Thanks for trying to help me and sorry again! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants