Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for limiting or skipping revert data in RawDeploy #146

Open
rory-ocl opened this issue Aug 20, 2024 · 1 comment
Open

Add options for limiting or skipping revert data in RawDeploy #146

rory-ocl opened this issue Aug 20, 2024 · 1 comment

Comments

@rory-ocl
Copy link
Contributor

The following methods have been temporarily removed as they were not fully implemented yet.

    /// Configures what portion of the revert data to copy in case of failure.
    /// Does not fail if out of bounds, but rather copies the overlapping portion.
    pub fn limit_revert_data(mut self, offset: usize, size: usize) -> Self {
        self.offset = offset;
        self.size = Some(size);
        self
    }

    /// Configures the call to avoid copying any revert data.
    /// Equivalent to `limit_revert_data(0, 0)`.
    pub fn skip_revert_data(self) -> Self {
        self.limit_revert_data(0, 0)
    }

These arguments will need to be added to hostios in order to be supported here.

@rory-ocl
Copy link
Contributor Author

These fields on RawDeploy can be re-added as well:

    offset: usize,
    size: Option<usize>,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant