Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list task #55

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Update list task #55

merged 3 commits into from
Dec 21, 2022

Conversation

DZGoldman
Copy link
Contributor

@DZGoldman DZGoldman commented Dec 14, 2022

This updates the "update" task, which takes a pre-existing arbified list as its input and ensures its up to date (which amounts to checking that each tokens gateways haven't changed).

(Compare to the "arbify" task which takes an L1 token list as its input and outputs an arbified list).

This PR let's the "includeOldDataFields" param be passed in via the command line; this preserves any data field in the extensions not included in the uniswap standard, for e.g. backwards compatibility (there are 3 for our whitelist era list).

It also allows a new "preserveListName" option (i.e., use the same old list name for the new, outputted list) which is (obviously) what we want for the update task (vs. for arbify where we give the list a new name).

We add the update task to /ArbTokenLists/arbed_arb_whitelist_era.json which indeed is the whitelist era list, live on the sever.

(The way list names / files name are handled can def be re-thought/simplified for the refactor)

fixes #51

@DZGoldman DZGoldman merged commit 62b5444 into all-tokens-list-gen Dec 21, 2022
@DZGoldman DZGoldman deleted the update-list-task branch December 21, 2022 17:36
@chrstph-dvx chrstph-dvx linked an issue Jan 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include whitelist era list in auto update task
2 participants