-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: docs-how-arbitrum-works #1866
Open
pete-vielhaber
wants to merge
37
commits into
master
Choose a base branch
from
docs-haw-reorg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pete-vielhaber
commented
Nov 26, 2024
- DRAFT DO NOT MERGE
- website/docusaurus.config.js
- lines 14-15 need changed back to 'throw'
- challenges.mdx
- line 156 is commented out due to error being thrown by yarn
- many links are broken, will fix once we have consensus on restructure
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TucksonDev
reviewed
Dec 12, 2024
TucksonDev
reviewed
Dec 12, 2024
TucksonDev
reviewed
Dec 12, 2024
TucksonDev
reviewed
Dec 12, 2024
TucksonDev
reviewed
Dec 12, 2024
TucksonDev
reviewed
Dec 12, 2024
TucksonDev
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @pete-vielhaber !
There are still a few things to change:
- I left comments in all sections that seem to break the regular reading flow
- There are many broken links throught all the document
- We need to place redirections from the old pages to the new ones. That's done in the
vercel.json
file - Some of the old pages are still active, even though they are not in the sidebar anymore. For example, Inside nitro, which is a page that's linked from many different places. If we want to keep the contents of these pages in the repo for a bit, one solution is to move them to
website/archive
. In any case, all links pointing to these pages should be changed, and redirections should be placed.
Let me know if you have any questions about any of the comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.