Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Hash operations should match AVM hash #5

Open
edfelten opened this issue May 19, 2020 · 1 comment
Open

Hash operations should match AVM hash #5

edfelten opened this issue May 19, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@edfelten
Copy link
Contributor

edfelten commented May 19, 2020 •
edited
Loading

The hashing of values, and correspondingly the hash and hash2 instructions, should use the same Keccak-256 hash as AVM. Currently they use convenient cryptographic hashes that don't match AVM.
@edfelten edfelten added the bug Something isn't working label May 19, 2020
@edfelten
Copy link
Contributor Author

edfelten commented Jul 1, 2020

This probably won't be fixed, because the standard AVM does size tracking for tuple structures, and incorporates size info into the hash, whereas the Rust emulator doesn't track sizes. Hashing of non-tuples should match AVM now, but tuple structures won't match.

rachel-bousfield added a commit that referenced this issue Sep 13, 2021
@rachel-bousfield
Merge pull request #5 from OffchainLabs/fix-rlp-decoding-overflow
e5ee0dd 
Fix overflow issue in RLP decoding
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edfelten