Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SC-11220] Deploy spark actions #449

Merged
merged 3 commits into from
Aug 30, 2023
Merged

[SC-11220] Deploy spark actions #449

merged 3 commits into from
Aug 30, 2023

Conversation

zerotucks
Copy link
Collaborator

Ticket URL

Please provide a link to the ticket:
https://app.shortcut.com/oazo-apps/story/11220/sc-deploy-spark-actions

Description of Changes

Please list the changes introduced by this PR:

  • Update docs to better reflect contract deployment process
  • Update types in DeploySystem class following deployment-config refactor (wasn't completed as part of that work)
  • Deploy Spark DMA actions to mainnet

PR Definition of Done

Please ensure the following requirements have been met before marking the PR as ready for review:

  • All checks are passing
  • PR is linked to a corresponding ticket
  • PR title is clear and concise
  • Code has been self-reviewed and any fixes or improvements noted (See Code review standards in Notion)
  • Documentation has been updated if necessary

@codesandbox
Copy link

codesandbox bot commented Aug 30, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@zerotucks zerotucks changed the base branch from dev to feature/spark-protocol August 30, 2023 08:31
marcinciarka
marcinciarka approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@marcinciarka marcinciarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zerotucks zerotucks merged commit 097ded8 into feature/spark-protocol Aug 30, 2023
1 check passed
@zerotucks zerotucks deleted the chore/jt/deploy-spark-actions branch August 30, 2023 08:58
@zerotucks zerotucks restored the chore/jt/deploy-spark-actions branch August 30, 2023 09:22
zerotucks added a commit that referenced this pull request Sep 5, 2023
@zerotucks @marcinciarka
[Feature] ✨ Spark Protocol (#452)
7927640 
* [SC-11338] Refactor Aave strategies dir structure/improve imports (#431)

refactor: aave strategies dir structure and improve imports

* [SC-11346] Standardise protocol addresses (#434)

* chore: add aave-like directory with addresses in operations directory

* refactor: swap out Aave specific addresses

* chore: removal of unnecessary checks and comments

* [SC-11219][DMA] Create spark actions (#436)

* chore: add aave-like directory with addresses in operations directory

* refactor: swap out Aave specific addresses

* chore: removal of unnecessary checks and comments

* chore: copy v3 actions across

* chore: add Spark types and interfaces

* refactor: AaveV3 Borrow to Spark Borrow

* refactor: AaveV3 Deposit to Spark Deposit

* refactor: Aave V3 Payback to Spark Payback

* refactor: Aave V3 EMode to Spark EMode

* refactor: Aave V3 Withdraw to Spark Withdraw

* chore: add service registry entry names for new actions

* chore: revert hardhat config changes

* [SC-11380] Placeholder Spark Addresses (#438)

* refactor: deployment configuration types and add in Spark

* chore: revert change to README.md

* chore: update Arbitrum config

* chore: update Hardhat deployment config

* chore: update local deployment config

* chore: add deployment config readme

* chore: update tenderly deployment config

* chore: update test deployment configs

* chore: address linting issues

* [SC-11217] Create spark action factories (#440)

* refactor: swap out Aave specific addresses

* chore: removal of unnecessary checks and comments

* chore: copy v3 actions across

* chore: revert hardhat config changes

* chore: create Spark action factory directory

* chore: create Spark action factories

* chore: export Spark actions from src/actions

* chore: remove rogue line following rebase

* [SC-11218] Spark (Borrow only) operations (#442)

* refactor: gather all common elements in aave-like directory

* feat: add Spark Borrow operation and definition

* feat: add Spark Deposit operation and definition

* feat: add Spark DepositBorrow operation and definition

* feat: add Spark OpenDepositBorrow operation file and definition

* feat: add Spark PaybackWithdraw operation and def

* chore: update type names on Spark multiply operations

* chore: address lint issues

* [SC-11220] Deploy spark actions (#449)

* chore: update README's, types in deploy class and deploy spark actions

* chore: update docs about post deployment

* chore: add missing SR name for AjnaRepayWithdraw back into mainnet config

* [SC-11216] Spark borrow strategies (#446)

* refactor: gather all common elements in aave-like directory

* feat: add Spark Borrow operation and definition

* feat: add Spark Deposit operation and definition

* feat: add Spark DepositBorrow operation and definition

* feat: add Spark OpenDepositBorrow operation file and definition

* feat: add Spark PaybackWithdraw operation and def

* chore: update type names on Spark multiply operations

* chore: address lint issues

* chore: copy across deposit-borrow strategy into aave-like

* refactor: how aave operations are exported

* refactor: aave depositBorrow strategy to use shared aaveLike strategy

* chore: fully export aave and spark depositBorrow strategies

* feat: creating AaveLike openDepositBorrow strategy

* Spark Borrow Incremental (#448)

* feat: WIP spark protocol data

* feat: implement spark protocol data layer

* feat: finish implementing spark view layer

* feat: fix op resolver and implement aave-like payback-withdraw

* fix: aave strategy exports

* feat: add payback-withdraw strategy into aave/spark

* chore: fix linting issues

* chore: move DPM flag to multiply on deps

* refactor: clean up strategies and views exports

* chore: restructure spark strategy exports

* refactor: simplify view layer

* Publish

 - @oasisdex/[email protected]
 - @oasisdex/[email protected]

* Publish

 - @oasisdex/[email protected]
 - @oasisdex/[email protected]

* chore: update build script

* Publish

 - @oasisdex/[email protected]
 - @oasisdex/[email protected]

* [Fix] Update getAaveTokenAddress to map ETH symbol to WETH (#454)

fix: update getAaveTokenAddress to map ETH symbol to WETH

* Publish

 - @oasisdex/[email protected]

* [SC-11391] Spark Multiply Operations (#455)

* feat: modify open aave-like op

* feat: update Spark Multiply Open Op

* feat: update Close Spark Multiply Op

* feat: update Adjust Down Spark Multiply Op

* feat: update Adjust Up Spark Multiply Op

* chore: fix linting issues

* [SC-11399][feat] Spark Open Multiply Strategy (#456)

* refactor: create protocol data resolver

* feat: create aave-like open multiply strategy

* refactor: integrate AaveLike Open Multiply into Aave/Spark

* chore: error msg in resolveProtocolData

* chore: remove eMode from V2 op entirely

* chore: address review points

* [SC-11221] Add Spark Operations to OpRegistry (#450)

* chore: Spark actions deploy true -> false

* feat: add ability to log out operation definitions to deploy system class

* chore: update docs and logOp helper

* chore: update docs

* chore: fix type issue and disable deployment of Service Registry and OpRegistry

* chore: more doc tweaks

* [SC-11399][feat] Spark Close Multiply Strategy (#459)

* feat: migrate aave/spark strategies to use AaveLike close strategy

* refactor: add storageIndex vars instead of magic numbers

* chore: remove unused type

* chore: address linting issues

* chore: fix type exports from Spark multiply

* chore: type fix strategy type exports for Aave

* chore: fix type issue

* [chore] bump parcel (#460)

chore: bump parcel

* chore: update types in all files in aavelike multiply adjust directory

* feat: add in flexible aaveLike operation resolver

* Revert "[chore] bump parcel (#460)" (#461)

This reverts commit 38804e6.

* feat: create adjust aave-like strategy

* feat: plugin Spark Adjust to aavelike strategy

* chore: remove AAVETokens

* chore: update deploy script and deploy definitions to log definition

* chore: revert config changes

* chore: clear up formatting issues

* feat: add buildOpenFlashloan function

* [SC-11399][feat] Spark Multiply Adjust Strategy (#462)

* chore: update types in all files in aavelike multiply adjust directory

* feat: add in flexible aaveLike operation resolver

* feat: create adjust aave-like strategy

* feat: plugin Spark Adjust to aavelike strategy

* chore: remove AAVETokens

* feat: add buildFlashloanOp to close and adjust

* [chore] add Spark Multiply Ops to registry (#463)

* chore: update types in all files in aavelike multiply adjust directory

* feat: add in flexible aaveLike operation resolver

* feat: create adjust aave-like strategy

* feat: plugin Spark Adjust to aavelike strategy

* chore: remove AAVETokens

* chore: update deploy script and deploy definitions to log definition

* chore: revert config changes

* chore: clear up formatting issues

* fix lint issue (maxLoanToValueForFL is moved to buildFlashloanSimArgs)

* fix lint issue

* bump alpha version

* typing werent included, redeployed as 0.4.20-alpha-2

* chore: address type clash issues

* fix: types

* Publish

 - @oasisdex/[email protected]
 - @oasisdex/[email protected]

* fix: missing exports

* Publish

 - @oasisdex/[email protected]

* Publish

 - @oasisdex/[email protected]
 - @oasisdex/[email protected]

---------

Co-authored-by: Marcin Ciarka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinciarka marcinciarka marcinciarka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zerotucks @marcinciarka