Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Chromium 121 #784

Closed
MaxIhlenfeldt opened this issue Jan 31, 2024 · 6 comments · Fixed by #791
Closed

Update to Chromium 121 #784

MaxIhlenfeldt opened this issue Jan 31, 2024 · 6 comments · Fixed by #791
Assignees

Comments

@MaxIhlenfeldt
Copy link
Collaborator

@MaxIhlenfeldt MaxIhlenfeldt self-assigned this Jan 31, 2024
@MaxIhlenfeldt
Copy link
Collaborator Author

Will start working on this as soon as I've cleaned up our patches to not include anything dunfell-specific any more. I'm doing test builds right now to verify the patches that are supposedly not needed for kirkstone and later releases actually aren't needed. Adding Rust to the build of course slowed it down even further, but I should be able to work on this update next week at the latest.

@MaxIhlenfeldt
Copy link
Collaborator Author

@kraj it turns out Chromium 121 has code that relies on std::pointer_traits being SFINAE, which was only recently implemented in libc++ in llvm/llvm-project@078651b. I think it might be easier to backport that patch to libc++ than to remove that requirement in Chromium - the diff is quite small. Would that be something that could live in meta-clang or should we add it in our layer using a .bbappend file?

@kraj
Copy link
Collaborator

kraj commented Feb 8, 2024

@MaxIhlenfeldt please propose a backport directly to meta-clang

@nrpt-m
Copy link
Contributor

nrpt-m commented Feb 14, 2024

@MaxIhlenfeldt, @rakuco
cc: @rwmacleod
Hi all, I am leaving WindRiver and from now on words @rjanani-p will support you for all the new Chromium PR testing.
It was great working with all of you and thanks for all the support !!

Best Regards,
Narpat Mali (@nrpt-m)

@rwmacleod
Copy link
Contributor

@nrpt-m thanks for all your work and for letting everyone know of your departure. Good luck with your new position.

@MaxIhlenfeldt
Copy link
Collaborator Author

@nrpt-m thank you for your contributions and testing, and all the best for your future endeavours!

@MaxIhlenfeldt MaxIhlenfeldt linked a pull request Feb 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants